Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor enhancement #4500

Merged
merged 6 commits into from
Aug 16, 2022
Merged

Some minor enhancement #4500

merged 6 commits into from
Aug 16, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Aug 9, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4155
#4489
#4497

Description:

  1. Add more ErrorCode
  2. Enhance ErrorCode display in show job
  3. Add a sleep flag to in stats job

Some minor enhancement to do in 3.0, see the related issues.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

SuperYoko
SuperYoko previously approved these changes Aug 9, 2022
Copy link
Contributor

@SuperYoko SuperYoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophie-Xie
Copy link
Contributor

Pls fix CI.

Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Sophie-Xie Sophie-Xie merged commit fc44449 into vesoft-inc:master Aug 16, 2022
@critical27 critical27 deleted the fix branch August 16, 2022 03:52
@foesa-yang foesa-yang self-requested a review October 13, 2022 05:53
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Oct 13, 2022
@foesa-yang foesa-yang added doc done PR:the doc for this PR is done. and removed doc affected PR: improvements or additions to documentation labels Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc done PR:the doc for this PR is done. ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants