Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what does show job Error Code “E_UNKNOWN“ mean #4155

Closed
dbacyj opened this issue Apr 14, 2022 · 6 comments
Closed

what does show job Error Code “E_UNKNOWN“ mean #4155

dbacyj opened this issue Apr 14, 2022 · 6 comments
Assignees
@critical27
Labels
type/bug Type: something is unexpected
Milestone
v3.3.0

Comments

@dbacyj
Copy link
Contributor

dbacyj commented Apr 14, 2022 •
edited
Loading

Describe the bug (required)
show job Error code show "E_UNKNOWN"，but finally show success

How To Reproduce(required)

Steps to reproduce the behavior:

  1. submit job stats
  2. show job x

image
image

Expected behavior
If thers is no error，the Error Code should be empty

Additional context
@dbacyj dbacyj added type/bug Type: something is unexpected type/feature req Type: feature request labels Apr 14, 2022
@dbacyj dbacyj changed the title what what does show job Error Code “E_UNKNOWN“ mean Apr 14, 2022
@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Apr 14, 2022
@panda-sheep
Copy link
Contributor

panda-sheep commented Apr 14, 2022 •
edited
Loading

The job status is running.
And the following error code is E_UNKOWN.
Is there any difference between empty and E_UNKOWN?

@dbacyj
Copy link
Contributor Author

dbacyj commented Apr 14, 2022

E_UNKOWN feels ambiguous，keep empty like Stop Time？

@Sophie-Xie Sophie-Xie added type/enhancement Type: make the code neat or more efficient and removed type/feature req Type: feature request labels Apr 14, 2022
@panda-sheep
Copy link
Contributor

E_UNKOWN feels ambiguous，keep empty like Stop Time？

I don't know if it's better to be blank or E_UNKOWN.
Because the job has not been executed.

@dbacyj
Copy link
Contributor Author

dbacyj commented Apr 14, 2022

E_UNKOWN feels ambiguous，keep empty like Stop Time？

I don't know if it's better to be blank or E_UNKOWN. Because the job has not been executed.

Since E_UNKNOWN has caused confusion for me and several others, I suggest using blank, which can be discussed later.

@panda-sheep
Copy link
Contributor

E_UNKOWN feels ambiguous，keep empty like Stop Time？

I don't know if it's better to be blank or E_UNKOWN. Because the job has not been executed.

Since E_UNKNOWN has caused confusion for me and several others, I suggest using blank, which can be discussed later.

Yeah，It can be discussed which form is better.

@jamieliu1023 jamieliu1023 mentioned this issue Apr 16, 2022
Closed
@Sophie-Xie
Copy link
Contributor

Change “E_UNKOWN" to blank

@Sophie-Xie Sophie-Xie removed the type/enhancement Type: make the code neat or more efficient label Apr 28, 2022
@Sophie-Xie Sophie-Xie added the priority/low-pri Priority: low label May 26, 2022
@Sophie-Xie Sophie-Xie modified the milestones: v3.2.0, v3.3.0 Jul 4, 2022
@Sophie-Xie Sophie-Xie removed the priority/low-pri Priority: low label Jul 4, 2022
@Sophie-Xie Sophie-Xie assigned critical27 and unassigned panda-sheep Aug 5, 2022
critical27 added a commit to critical27/nebula that referenced this issue Aug 9, 2022
@critical27
fix vesoft-inc#4155
f56a986
@critical27 critical27 mentioned this issue Aug 9, 2022
Merged
11 tasks
@wey-gu wey-gu mentioned this issue Aug 20, 2022
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @critical27
Some minor enhancement (vesoft-inc#1170)
ac0944e 
## What type of PR is this?
- [ ] bug
- [ ] feature
- [X] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 
vesoft-inc#4155 
vesoft-inc#4489
vesoft-inc#4497

#### Description:
1. Add more ErrorCode
2. Enhance ErrorCode display in show job 
3. Add a sleep flag to in stats job

Some minor enhancement to do in 3.0, see the related issues.

## How do you solve it?



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [X] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4500

Co-authored-by: Doodle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@critical27 critical27

Labels
type/bug Type: something is unexpected
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
4 participants
@critical27 @panda-sheep @dbacyj @Sophie-Xie