Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong space key after dropping hosts #4182

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

liwenhui-soul
Copy link
Contributor

@liwenhui-soul liwenhui-soul commented Apr 19, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@liwenhui-soul liwenhui-soul added the ready-for-testing PR: ready for the CI test label Apr 19, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 19, 2022
@critical27
Copy link
Contributor

critical27 commented Apr 20, 2022

Do we support drop several hosts at the same time?

Suppose we have a space s1 with only one replica on [z1, z2, z3], each zone has one host, which is [h1, h2, h3]. If we execute DROP HOST h2, h3, base on current implementation, s1's zone list would be either [z1, z2] or [z1, z3], not [z1]. The reason is that checkRelatedSpaceAndCollect is modify the zone list based on data in rocksdb....

That's why we need spaceMap. Correct me if I am wrong....

And we'd better add a test case in TCK later

@HarrisChu
Copy link
Contributor

Do we support drop several hosts at the same time?

yes, support

@liwenhui-soul
Copy link
Contributor Author

Do we support drop several hosts at the same time?

Suppose we have a space s1 with only one replica on [z1, z2, z3], each zone has one host, which is [h1, h2, h3]. If we execute DROP HOST h2, h3, base on current implementation, s1's zone list would be either [z1, z2] or [z1, z3], not [z1]. The reason is that checkRelatedSpaceAndCollect is modify the zone list based on data in rocksdb....

That's why we need spaceMap. Correct me if I am wrong....

And we'd better add a test case in TCK later

fixed

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophie-Xie Sophie-Xie merged commit f8c67bd into vesoft-inc:master Apr 20, 2022
Sophie-Xie added a commit that referenced this pull request Apr 20, 2022
Sophie-Xie added a commit that referenced this pull request Apr 20, 2022
* fix issue 4152 (#4158)

* Fix optional of multi-match (#4159)

* fix optional of multi-match

* format

Co-authored-by: Sophie <[email protected]>

* Fix incompatibility imported by #4116 (#4165)

* Add SaveGraphVersionProcessor to separate client version check and version saving

* Update error code

* Update error code

* optimizer path (#4162)

* optimizer multi-shortest path

* new algorithm

* fix error

* skip heartbeat for tool (#4177)

Co-authored-by: Sophie <[email protected]>

* Fix/null pattern expression input (#4180)

* Move input rows of Traverse and AppendVertices.

* Avoid skip validate pattern expression with aggregate.

* Fix case.

* Revert "Move input rows of Traverse and AppendVertices."

This reverts commit 7fd1d38.

Co-authored-by: Sophie <[email protected]>

* fix wrong space key after dropping hosts (#4182)

Co-authored-by: Sophie <[email protected]>

* fix vertex is missing from snapshot (#4189)

Co-authored-by: Sophie <[email protected]>

* Expression is stateful to store the result of evaluation, so we can't… (#4190)

* Expression is stateful to store the result of evaluation, so we can't share it inter threads.

* Fix defef nullptr.

Co-authored-by: jie.wang <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: shylock <[email protected]>
Co-authored-by: liwenhui-soul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants