Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer path #4162

Merged
merged 3 commits into from
Apr 19, 2022
Merged

optimizer path #4162

merged 3 commits into from
Apr 19, 2022

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Apr 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Data Structure(Previous version)
unordered_map<Value(dstVid), vector<Path> > prePaths;
Only keep dstVid and the paths to the dstVid,
There will be the following problems

path (1)

Topology is graph 1
problem one : redundant path
As shown in table 1, the third step will start from the two vids C and D to expand, if the start vid information is saved as shown in table 2, the third step only needs to expand from the vid D

problem two : time complexity
comparing graph 1 and graph 2, in the conjunctPath stage, the paths can be grouped according to the startVid, and the time complexity will be reduced

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (26f8fc8) to head (24eb885).
Report is 629 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4162      +/-   ##
==========================================
+ Coverage   84.94%   84.95%   +0.01%     
==========================================
  Files        1319     1321       +2     
  Lines      131077   131180     +103     
==========================================
+ Hits       111343   111450     +107     
+ Misses      19734    19730       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nevermore3 nevermore3 added this to the v3.1.0 milestone Apr 19, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 19, 2022
@Sophie-Xie Sophie-Xie merged commit 02bdc67 into vesoft-inc:master Apr 19, 2022
@nevermore3 nevermore3 deleted the optimize_path branch April 19, 2022 09:35
Sophie-Xie pushed a commit that referenced this pull request Apr 20, 2022
* optimizer multi-shortest path

* new algorithm

* fix error
Sophie-Xie added a commit that referenced this pull request Apr 20, 2022
* fix issue 4152 (#4158)

* Fix optional of multi-match (#4159)

* fix optional of multi-match

* format

Co-authored-by: Sophie <[email protected]>

* Fix incompatibility imported by #4116 (#4165)

* Add SaveGraphVersionProcessor to separate client version check and version saving

* Update error code

* Update error code

* optimizer path (#4162)

* optimizer multi-shortest path

* new algorithm

* fix error

* skip heartbeat for tool (#4177)

Co-authored-by: Sophie <[email protected]>

* Fix/null pattern expression input (#4180)

* Move input rows of Traverse and AppendVertices.

* Avoid skip validate pattern expression with aggregate.

* Fix case.

* Revert "Move input rows of Traverse and AppendVertices."

This reverts commit 7fd1d38.

Co-authored-by: Sophie <[email protected]>

* fix wrong space key after dropping hosts (#4182)

Co-authored-by: Sophie <[email protected]>

* fix vertex is missing from snapshot (#4189)

Co-authored-by: Sophie <[email protected]>

* Expression is stateful to store the result of evaluation, so we can't… (#4190)

* Expression is stateful to store the result of evaluation, so we can't share it inter threads.

* Fix defef nullptr.

Co-authored-by: jie.wang <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: shylock <[email protected]>
Co-authored-by: liwenhui-soul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants