Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable console pkg #4110

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Apr 1, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Temporarily disable packaging of the nebula-console.
The normal packaging process must artificially ensure that both nebula and nebula-console have available and consistent branches before packaging, but due to the dependencies between nebula and nebula-console, some errors will reduce the efficiency of ci.

How do you solve it?

Just disable the packaging switch related with nebula-console.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango force-pushed the disable-console-pkg branch from 3fc2e50 to 34d586a Compare April 1, 2022 09:34
@czpmango czpmango force-pushed the disable-console-pkg branch from 34d586a to 16fdc3f Compare April 1, 2022 09:34
@czpmango czpmango requested a review from yixinglu April 1, 2022 09:34
@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Apr 1, 2022
Aiee
Aiee previously approved these changes Apr 1, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 1, 2022
.gitignore Outdated Show resolved Hide resolved
@Sophie-Xie Sophie-Xie merged commit abd7355 into vesoft-inc:master Apr 1, 2022
Sophie-Xie pushed a commit that referenced this pull request Apr 3, 2022
* disable console pkg

* fix
CPWstatic added a commit that referenced this pull request Apr 3, 2022
* fix memory leak (#4103)

* Param MATCH vid seek fix (#4024)

* Add qctx to isEvaluableExpr for kRelIn

Fixing MATCH (n) WHERE id(n) IN [$t] RETURN n

* Fix eq kVal parameter vidseek

* Fix id(n) IN [$var] case

* lint add explicit and remove tailing semicolon

* clang-format-10

* double check type of rightListValue

Addressing Kyle's review comment

* ut added in features/yield/parameter.feature

* support kAttribute

match (n) where n in $list_var return n

* Add kSubscript for eq case

MATCH (v) WHERE id(v) == $p7.a.b.d[4] RETURN v

Co-authored-by: Sophie <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: cpw <[email protected]>

* disable console pkg (#4110)

* disable console pkg

* fix

* disable console pkg (#4112)

* Fix service crash caused by using function call as a part of the filter in `LOOKUP` (#4111)

* Fix function call purity check

* Add UT for purity check

* Add TCK cases

* Fix cmake command error (#4114)

Co-authored-by: yaphet <[email protected]>
Co-authored-by: Wey Gu <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: cpw <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants