Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak #4103

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix memory leak #4103

merged 1 commit into from
Apr 1, 2022

Conversation

darionyaphet
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label Mar 31, 2022
@Sophie-Xie Sophie-Xie requested a review from panda-sheep March 31, 2022 04:42
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 31, 2022
panda-sheep
panda-sheep previously approved these changes Mar 31, 2022
@czpmango
Copy link
Contributor

parser.yy:3284 add:

delete($5);

@critical27
Copy link
Contributor

Don't merge, still leaked

@Sophie-Xie Sophie-Xie merged commit 65dd2f3 into vesoft-inc:master Apr 1, 2022
@darionyaphet darionyaphet deleted the fix-0331 branch April 1, 2022 03:17
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 1, 2022
Sophie-Xie pushed a commit that referenced this pull request Apr 3, 2022
CPWstatic added a commit that referenced this pull request Apr 3, 2022
* fix memory leak (#4103)

* Param MATCH vid seek fix (#4024)

* Add qctx to isEvaluableExpr for kRelIn

Fixing MATCH (n) WHERE id(n) IN [$t] RETURN n

* Fix eq kVal parameter vidseek

* Fix id(n) IN [$var] case

* lint add explicit and remove tailing semicolon

* clang-format-10

* double check type of rightListValue

Addressing Kyle's review comment

* ut added in features/yield/parameter.feature

* support kAttribute

match (n) where n in $list_var return n

* Add kSubscript for eq case

MATCH (v) WHERE id(v) == $p7.a.b.d[4] RETURN v

Co-authored-by: Sophie <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: cpw <[email protected]>

* disable console pkg (#4110)

* disable console pkg

* fix

* disable console pkg (#4112)

* Fix service crash caused by using function call as a part of the filter in `LOOKUP` (#4111)

* Fix function call purity check

* Add UT for purity check

* Add TCK cases

* Fix cmake command error (#4114)

Co-authored-by: yaphet <[email protected]>
Co-authored-by: Wey Gu <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: cpw <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants