Integrate raft into storage #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins go |
|
Unit testing passed. |
dangleptr
reviewed
May 23, 2019
|
jenkins go |
|
Unit testing passed. |
dangleptr
reviewed
May 28, 2019
|
Unit testing passed. |
laura-ding
reviewed
May 30, 2019
| @@ -83,19 +83,29 @@ StatusOr<std::unordered_map<std::string, std::string>> NetworkUtils::listDeviceA | |||
| return dev2ipv4s; | |||
| } | |||
|
|
|||
|
|
|||
| bool NetworkUtils::getDynamicPortRange(uint16_t& low, uint16_t& high) { | |||
There was a problem hiding this comment.
Does return value use StatusOr?
There was a problem hiding this comment.
Not quite understand why we need StatusOr here
dangleptr
reviewed
Jun 3, 2019
All UTs pass. At the moment, all parts still running with single copy. Will enable multiple copies in the future PR Implemented #178
Rebased as well
dangleptr
approved these changes
Jun 5, 2019
| cb(ret, HostAddr(0, 0)); | ||
|
|
||
| wal::BufferFlusher* getBufferFlusher() { | ||
| static wal::BufferFlusher flusher; |
There was a problem hiding this comment.
Only one flusher maybe a bottleneck. Let's open another issue to make the number configurable.
There was a problem hiding this comment.
We could make the number of flushing threads in the BufferFlusher configurable
Sure. let's do it in a separate PR
|
Unit testing passed. |
|
Unit testing passed. |
This was referenced Jun 6, 2019
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* Integrate raft into storage All UTs pass. At the moment, all parts still running with single copy. Will enable multiple copies in the future PR Implemented vesoft-inc#178 * Addressed @dangleptr's comments and rebased * Addressed @dangleptr's comments and rebased * Addressed @laura-ding's @dangleptr's comments Rebased as well
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Integrate raft into storage All UTs pass. At the moment, all parts still running with single copy. Will enable multiple copies in the future PR Implemented vesoft-inc#178 * Addressed @dangleptr's comments and rebased * Addressed @dangleptr's comments and rebased * Addressed @laura-ding's @dangleptr's comments Rebased as well
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Force push so that nebula dev could switch to third-party 3.0 Co-authored-by: Sherman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All UTs pass. At the moment, all parts still running with single copy. Will enable multiple copies in the future PR
Implemented #178