Support edge in meta service #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
requested review from
dutor,
sherman-the-tank,
dangleptr and
laura-ding
|
Unit testing passed. |
dangleptr
reviewed
May 13, 2019
src/interface/meta.thrift
Outdated
| @@ -77,6 +76,11 @@ struct EdgeItem { | |||
| 4: common.Schema schema, | |||
| } | |||
|
|
|||
| struct AlterEdgeItem { | |||
There was a problem hiding this comment.
It seems that we have unified AlterTagItem and AlterEdgeItem to AlterSchemaItem.
|
Unit testing failed. |
laura-ding
reviewed
May 13, 2019
|
Unit testing failed. |
1 similar comment
|
Unit testing failed. |
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* support edge in meta service * support leader
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* support edge in meta service * support leader
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* Fix the latency type in the executionResponse * Fix compilation * Fix comment Co-authored-by: Yichen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is included by Add AlterEdgeProcessor, GetEdgeProcessor, RemoveEdgeProcessor and UTs and support some meta client's method.
Please hold on this one and complete later thanks :)