Add AlterEdgeProcessor, GetEdgeProcessor, RemoveEdgeProcessor and UTs #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing passed. |
dangleptr
reviewed
May 10, 2019
| folly::SharedMutex::ReadHolder rHolder(LockUtils::edgeLock()); | ||
| std::string val; | ||
| std::string edgeKey = MetaServiceUtils::schemaEdgeKey(req.get_space_id(), | ||
| req.get_edge_type(), |
| } | ||
|
|
||
| StatusOr<std::vector<std::string>> RemoveEdgeProcessor::getEdgeKeys(GraphSpaceID id, | ||
| const std::string& edgeName) { |
src/meta/test/ProcessorTest.cpp
Outdated
| auto addItem = cpp2::AlterTagItem(FRAGILE, | ||
| cpp2::AlterTagOp::ADD, | ||
| auto addItem = cpp2::AlterSchemaItem(FRAGILE, | ||
| cpp2::AlterSchemaOp::ADD, |
| onFinished(); | ||
| return; | ||
| } | ||
| folly::SharedMutex::WriteHolder wHolder(LockUtils::tagLock()); |
| for (auto& col : cols) { | ||
| auto retCode = MetaServiceUtils::alterColumnDefs(columns, col, edgeItem.op); | ||
| if (retCode != cpp2::ErrorCode::SUCCEEDED) { | ||
| LOG(WARNING) << "Alter edge error"; |
There was a problem hiding this comment.
Output the retCode in LOG
|
Rename the issue's title by the way. It not only adds UTs. |
laura-ding
changed the title
|
Unit testing passed. |
|
LGTM now. Fix the conflicts |
modify SET to CHANGE
|
Unit testing failed. |
|
Unit testing passed. |
|
Unit testing passed. |
This was referenced May 13, 2019
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
…vesoft-inc#346) * add AlterEdgeProcessor, GetEdgeProcessor, RemoveEdgeProcessor * address dangleptr's comment * rebase master modify SET to CHANGE * fix UT
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…vesoft-inc#346) * add AlterEdgeProcessor, GetEdgeProcessor, RemoveEdgeProcessor * address dangleptr's comment * rebase master modify SET to CHANGE * fix UT
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: Shylock Hg <[email protected]> Co-authored-by: Sophie <[email protected]> Co-authored-by: sworduo <[email protected]> Co-authored-by: Shylock Hg <[email protected]> Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add AlterEdgeProcessor, GetEdgeProcessor, RemoveEdgeProcessor