Support leader change in meta client && do some refactors #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing passed. |
laura-ding
reviewed
May 11, 2019
src/meta/client/MetaClient.cpp
Outdated
| remoteFunc(client, std::move(req)) | ||
| .then(evb, [p = std::move(pro), respGen, this] (folly::Try<RpcResponse>&& t) mutable { | ||
| // exception occurred during RPC | ||
| if (t.hasException()) { | ||
| p.setValue(Status::Error(folly::stringPrintf("RPC failure in MetaClient: %s", | ||
| t.exception().what().c_str()))); | ||
| { | ||
| folly::RWSpinLock::WriteHolder holder(hostLock_); |
There was a problem hiding this comment.
Why not put hostLock_ inside updateHost()？
There was a problem hiding this comment.
Sounds reasonable
| @@ -35,7 +35,7 @@ ServerBasedSchemaManager::getTagSchema(GraphSpaceID space, TagID tag, SchemaVer | |||
| if (ver < 0) { | |||
| ver = getNewestTagSchemaVer(space, tag); | |||
| } | |||
| auto ret = metaClient_->getTagSchemeFromCache(space, tag, ver); | |||
| auto ret = metaClient_->getTagSchemaFromCache(space, tag, ver); | |||
| return Status::Error("existed!"); | ||
| case cpp2::ErrorCode::E_NOT_FOUND: | ||
| return Status::Error("not existed!"); | ||
| case cpp2::ErrorCode::E_LEADER_CHANGED: { |
There was a problem hiding this comment.
When the leader changes ，getResponse() returns the error code E_LEADER_CHANGED, then the resend message is triggered by the trigger itself(Sometimes is users, but they don't need know this).
Why not try to resend through getResponse() or unified process?
There was a problem hiding this comment.
Retry logic is another story not related to this pr.
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…#354) * Support leader change in meta client && do some refactors * Address @laura-ding's comments * Fix remove tag schema bug
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: kyle.cao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of #283