Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Remove unnecessary check #3112

Merged
merged 7 commits into from
Oct 19, 2021
Merged

[Minor] Remove unnecessary check #3112

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ad847c
Remove unnecessary check
Aiee Oct 18, 2021
b1e28a7
Merge branch 'master' into fix-opt-rule
Aiee Oct 18, 2021
a7f91cb
Merge branch 'master' into fix-opt-rule
Aiee Oct 18, 2021
c570139
Merge branch 'master' into fix-opt-rule
Aiee Oct 18, 2021
b38bb72
Merge branch 'master' into fix-opt-rule
CPWstatic Oct 19, 2021
4277872
Merge branch 'master' into fix-opt-rule
yixinglu Oct 19, 2021
41206e5
Merge branch 'master' into fix-opt-rule
Aiee Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/graph/optimizer/rule/UnionAllIndexScanBaseRule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace nebula {
namespace opt {

// The matched expression should be either a OR expression or an expression that could be
// rewrote to a OR expression. There are 3 senarios.
// rewrote to a OR expression. There are 3 scenarios.
//
// 1. OR expr. If OR expr has an IN expr operand that has a valid index, expand it to OR expr.
//
Expand Down Expand Up @@ -162,8 +162,7 @@ StatusOr<TransformResult> UnionAllIndexScanBaseRule::transform(OptContext* ctx,
break;
}

DCHECK(transformedExpr->kind() == ExprKind::kLogicalOr ||
transformedExpr->kind() == ExprKind::kRelEQ);
DCHECK(transformedExpr->kind() == ExprKind::kLogicalOr);
std::vector<IndexQueryContext> idxCtxs;
auto logicalExpr = static_cast<const LogicalExpression*>(transformedExpr);
for (auto operand : logicalExpr->operands()) {
Expand Down