-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Remove unnecessary check #3112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
added
type/bug
Type: something is unexpected
cherry-pick-v2.6
PR: need cherry-pick to this version
labels
Oct 18, 2021
jievince
approved these changes
Oct 18, 2021
yixinglu
approved these changes
Oct 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #3112 +/- ##
==========================================
+ Coverage 84.30% 85.00% +0.70%
==========================================
Files 1287 1287
Lines 115636 115780 +144
==========================================
+ Hits 97483 98415 +932
+ Misses 18153 17365 -788
Continue to review full report at Codecov.
|
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 20, 2021
Co-authored-by: cpw <[email protected]> Co-authored-by: Yee <[email protected]>
bright-starry-sky
pushed a commit
that referenced
this pull request
Oct 20, 2021
* Fixed an issue where the server still started with a wrong ip/host (#3057) * Fix wrong local ip. * Address comment. * Fix alter drop (#3036) * disable modify same col * add test case * refactor ddl * fix pytest error * address comment Co-authored-by: Yee <[email protected]> * fix fetch vertex properties(vertex) bug (#3120) * fix fetch vertex properties(vertex) bug * address comment Co-authored-by: Yee <[email protected]> * fix go yield bug (#3128) * fix go yield bug * add test case * Remove unnecessary check (#3112) Co-authored-by: cpw <[email protected]> Co-authored-by: Yee <[email protected]> * fix go mTOn filter bug (#3144) * fix go mTOn filter bug * add test case * Geo spatial: 3. geography schema, data, index and optimization (#3043) * Geo spatial: 3. geography data and index Co-authored-by: cpw <[email protected]> Co-authored-by: jimingquan <[email protected]> Co-authored-by: Yee <[email protected]> Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: jie.wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-v2.6
PR: need cherry-pick to this version
ready-for-testing
PR: ready for the CI test
type/bug
Type: something is unexpected
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.