Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Remove unnecessary check #3112

Merged
merged 7 commits into from
Oct 19, 2021
Merged

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Oct 18, 2021

As title.

@Aiee Aiee added type/bug Type: something is unexpected cherry-pick-v2.6 PR: need cherry-pick to this version labels Oct 18, 2021
@Aiee Aiee requested review from yixinglu and jievince October 18, 2021 03:29
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Oct 18, 2021
@Aiee Aiee added the ready-for-testing PR: ready for the CI test label Oct 18, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3112 (c570139) into master (fb3be74) will increase coverage by 0.70%.
The diff coverage is 70.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3112      +/-   ##
==========================================
+ Coverage   84.30%   85.00%   +0.70%     
==========================================
  Files        1287     1287              
  Lines      115636   115780     +144     
==========================================
+ Hits        97483    98415     +932     
+ Misses      18153    17365     -788     
Impacted Files Coverage Δ
src/clients/storage/InternalStorageClient.cpp 0.00% <0.00%> (ø)
src/kvstore/NebulaStore.h 94.73% <ø> (-0.51%) ⬇️
src/kvstore/Part.h 100.00% <ø> (ø)
.../storage/transaction/ChainAddEdgesProcessorLocal.h 40.00% <ø> (ø)
...orage/transaction/ChainAddEdgesProcessorRemote.cpp 0.00% <0.00%> (ø)
...storage/transaction/ChainAddEdgesProcessorRemote.h 0.00% <ø> (ø)
src/storage/transaction/ChainResumeProcessor.cpp 11.42% <0.00%> (+11.42%) ⬆️
src/storage/transaction/ConsistUtil.cpp 17.50% <0.00%> (-0.61%) ⬇️
src/storage/transaction/ConsistUtil.h 33.33% <ø> (ø)
src/storage/transaction/ResumeAddEdgeProcessor.cpp 0.00% <0.00%> (ø)
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0fb27a...c570139. Read the comment docs.

@yixinglu yixinglu merged commit 81427ea into vesoft-inc:master Oct 19, 2021
Sophie-Xie pushed a commit that referenced this pull request Oct 20, 2021
bright-starry-sky pushed a commit that referenced this pull request Oct 20, 2021
* Fixed an issue where the server still started with a wrong ip/host (#3057)

* Fix wrong local ip.

* Address comment.

* Fix alter drop (#3036)

* disable modify same col

* add test case

* refactor ddl

* fix pytest error

* address comment

Co-authored-by: Yee <[email protected]>

* fix fetch vertex properties(vertex) bug (#3120)

* fix fetch vertex properties(vertex) bug

* address comment

Co-authored-by: Yee <[email protected]>

* fix go yield bug (#3128)

* fix go yield bug

* add test case

* Remove unnecessary check (#3112)

Co-authored-by: cpw <[email protected]>
Co-authored-by: Yee <[email protected]>

* fix go mTOn filter bug (#3144)

* fix go mTOn filter bug

* add test case

* Geo spatial: 3. geography schema, data, index and optimization (#3043)

* Geo spatial: 3. geography data and index

Co-authored-by: cpw <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: Yee <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: jie.wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v2.6 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants