Expression test modify #3041
Merged
Expression test modify #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohaifei
added
ready-for-testing
zhaohaifei
requested review from
CPWstatic,
nevermore3,
Aiee,
yixinglu and
Shylock-Hg
Codecov Report
@@ Coverage Diff @@
## master #3041 +/- ##
==========================================
+ Coverage 84.20% 84.22% +0.02%
==========================================
Files 1287 1287
Lines 115319 115625 +306
==========================================
+ Hits 97100 97386 +286
- Misses 18219 18239 +20
Continue to review full report at Codecov.
|
Shylock-Hg
reviewed
Oct 13, 2021
| @@ -60,7 +60,12 @@ TEST_F(FunctionCallExpressionTest, FunctionCallTest) { | |||
| path.src.vid = "1"; | |||
| STEP("2", "edge", 0, 1); | |||
| STEP("1", "edge", 0, -1); | |||
| TEST_FUNCTION(hasSameEdgeInPath, {path}, true); | |||
There was a problem hiding this comment.
I think you should provide some new test utilities instead of expand them.
There was a problem hiding this comment.
Why don't use TEST_FUNCTION?
There was a problem hiding this comment.
TEST_FUNCTION is a parser process, here cannot construct a sentence to call parser.
nevermore3
approved these changes
Oct 13, 2021
yixinglu
reviewed
Oct 13, 2021
Not to improve, but to verify the correctness of the original expression。 |
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 15, 2021
* modify expression test * modify expression test 2 * complete coding * fix bug * modify expression test case * clang-format * fix bug:initialization-order-fiasco * add some obj * add test_path_function Co-authored-by: cpw <[email protected]>
yixinglu
added a commit
that referenced
this pull request
Oct 18, 2021
* Expression test modify (#3041) * modify expression test * modify expression test 2 * complete coding * fix bug * modify expression test case * clang-format * fix bug:initialization-order-fiasco * add some obj * add test_path_function Co-authored-by: cpw <[email protected]> * add hash<set> & hash<map> (#3051) * fix dangling edge in path (#3008) * fix dangling edge * add test case * fix ci error * Fix graph/meta/storage version in show hosts (#3054) * Fix graph version bug * Fix storage version * Print cpack config * Decrease ubuntu compile parallelism * fix bug #3048 (#3069) Co-authored-by: haifei.zhao <[email protected]> Co-authored-by: cpw <[email protected]> Co-authored-by: jimingquan <[email protected]> Co-authored-by: Yee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background：
Since the original repos are separate, the nebula/src/common/expression/test module is written based on the original repo：nebula-common. The parser module in nebual-graph cannot be called directly. Now that the repos are merged, we want to directly call the parser module to do the test.