Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dangling edge in path #3008

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Conversation

nevermore3
Copy link
Contributor

fix #2899

@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Oct 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3008 (63bbd56) into master (9462d35) will decrease coverage by 0.06%.
The diff coverage is 89.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
- Coverage   84.40%   84.34%   -0.07%     
==========================================
  Files        1284     1283       -1     
  Lines      113608   113682      +74     
==========================================
- Hits        95888    95882       -6     
- Misses      17720    17800      +80     
Impacted Files Coverage Δ
src/clients/storage/StorageClientBase-inl.h 79.04% <0.00%> (-3.70%) ⬇️
src/common/thrift/ThriftClientManager.h 100.00% <ø> (ø)
src/daemons/GraphDaemon.cpp 65.13% <ø> (ø)
src/graph/executor/Executor.h 100.00% <ø> (ø)
src/graph/executor/query/GetPropExecutor.h 70.58% <ø> (-1.64%) ⬇️
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <ø> (-0.31%) ⬇️
src/graph/service/GraphService.h 100.00% <ø> (ø)
src/graph/service/QueryEngine.h 100.00% <ø> (ø)
src/graph/util/Utils.h 100.00% <ø> (ø)
src/graph/executor/query/FilterExecutor.cpp 85.71% <25.00%> (-3.58%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e642c05...63bbd56. Read the comment docs.

@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Oct 8, 2021
@nevermore3 nevermore3 force-pushed the fix_dangling_edge branch 2 times, most recently from 4a98c15 to f07ef9a Compare October 8, 2021 07:13
yixinglu
yixinglu previously approved these changes Oct 8, 2021
@nevermore3 nevermore3 added the cherry-pick-v2.6 PR: need cherry-pick to this version label Oct 11, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPWstatic CPWstatic merged commit 1f78224 into vesoft-inc:master Oct 14, 2021
Sophie-Xie pushed a commit that referenced this pull request Oct 15, 2021
* fix dangling edge

* add test case

* fix ci error
yixinglu added a commit that referenced this pull request Oct 18, 2021
* Expression test modify (#3041)

* modify expression test

* modify expression test 2

* complete coding

* fix bug

* modify expression test case

* clang-format

* fix bug:initialization-order-fiasco

* add some obj

* add test_path_function

Co-authored-by: cpw <[email protected]>

* add hash<set> & hash<map> (#3051)

* fix  dangling edge in path (#3008)

* fix dangling edge

* add test case

* fix ci error

* Fix graph/meta/storage version in show hosts (#3054)

* Fix graph version bug

* Fix storage version

* Print cpack config

* Decrease ubuntu compile parallelism

* fix bug #3048 (#3069)

Co-authored-by: haifei.zhao <[email protected]>
Co-authored-by: cpw <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: Yee <[email protected]>
@nevermore3 nevermore3 deleted the fix_dangling_edge branch October 20, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v2.6 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dangling edge will return a null vertex when use "find path with prop"
6 participants