Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check .git before compiling #276

Merged
merged 3 commits into from
Apr 19, 2019
+19 −14
Merged

Check .git before compiling #276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19491de
check .git before create pre-commit hook
darionyaphet Apr 15, 2019
0193e58
Merge branch 'master' into issues-273
darionyaphet Apr 17, 2019
9b915b3
Merge branch 'master' into issues-273
darionyaphet Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,19 +310,24 @@ add_custom_target(
)


# Create the pre-commit hook every time we run cmake
set(PRE_COMMIT_HOOK ${CMAKE_CURRENT_SOURCE_DIR}/.git/hooks/pre-commit)
execute_process(
COMMAND
"rm" "-f" ${PRE_COMMIT_HOOK}
)
execute_process(
COMMAND
"ln" "-s" ${CMAKE_CURRENT_SOURCE_DIR}/cpplint/bin/pre-commit.sh ${PRE_COMMIT_HOOK}
RESULT_VARIABLE retcode
)
IF(${retcode} EQUAL 0)
MESSAGE(STATUS "Creating pre-commit hook done")
IF(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/.git/")
# Create the pre-commit hook every time we run cmake
message(STATUS "Create the pre-commit hook")
set(PRE_COMMIT_HOOK ${CMAKE_CURRENT_SOURCE_DIR}/.git/hooks/pre-commit)
execute_process(
COMMAND
"rm" "-f" ${PRE_COMMIT_HOOK}
)
execute_process(
COMMAND
"ln" "-s" ${CMAKE_CURRENT_SOURCE_DIR}/cpplint/bin/pre-commit.sh ${PRE_COMMIT_HOOK}
RESULT_VARIABLE retcode
)
IF(${retcode} EQUAL 0)
MESSAGE(STATUS "Creating pre-commit hook done")
ELSE()
MESSAGE(FATAL_ERROR "Creating pre-commit hook failed: ${retcode}")
ENDIF()
ELSE()
MESSAGE(FATAL_ERROR "Creating pre-commit hook failed: ${retcode}")
MESSAGE(FATAL_ERROR "Currently, we don't support downloaded source code.\nPlease using git clone it and rebuild.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open another issue to fix it in the future.

ENDIF()