Check .git before compiling #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
reviewed
Apr 15, 2019
dutor
reviewed
Apr 15, 2019
|
Unit testing passed. |
|
Because we use git to manage our third-party resources, IMO we could force our users to use git clone instead of download resource directly. |
Sounds good :) When I find it's not a |
|
Unit testing passed. |
darionyaphet
changed the title
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
dangleptr
previously approved these changes
Apr 17, 2019
| ELSE() | ||
| MESSAGE(FATAL_ERROR "Creating pre-commit hook failed: ${retcode}") | ||
| MESSAGE(FATAL_ERROR "Currently, we don't support downloaded source code.\nPlease using git clone it and rebuild.") |
There was a problem hiding this comment.
Open another issue to fix it in the future.
|
Unit testing passed. |
2 similar comments
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
dangleptr
approved these changes
Apr 19, 2019
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* fix a bug may stuck * update Co-authored-by: Yee <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Yee <[email protected]>
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* fix a bug may stuck * update Co-authored-by: Yee <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Yee <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Yee <[email protected]>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check .git before create pre-commit hook