Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick some bug fix from 2.0 #2465

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Conversation

critical27
Copy link
Contributor

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Apr 2, 2021
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

Codecov Report

Merging #2465 (4d3a052) into master (2249c03) will decrease coverage by 0.28%.
The diff coverage is 82.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2465      +/-   ##
==========================================
- Coverage   86.46%   86.18%   -0.29%     
==========================================
  Files         649      647       -2     
  Lines       64374    67233    +2859     
==========================================
+ Hits        55662    57944    +2282     
- Misses       8712     9289     +577     
Impacted Files Coverage Δ
src/common/base/EitherOr.h 95.69% <ø> (ø)
src/common/base/StatusOr.h 91.85% <ø> (ø)
src/common/filter/geo/GeoParams.h 100.00% <ø> (ø)
src/common/fs/FileUtils.h 85.71% <ø> (ø)
src/common/hdfs/HdfsCommandHelper.cpp 0.00% <0.00%> (-75.00%) ⬇️
src/common/stats/StatsManager.h 100.00% <ø> (ø)
src/common/time/Duration.cpp 75.86% <ø> (ø)
src/common/time/Duration.h 100.00% <ø> (ø)
src/common/time/detail/TscHelper.cpp 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.cpp 92.16% <0.00%> (-5.29%) ⬇️
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02bf8aa...4d3a052. Read the comment docs.

@yixinglu yixinglu merged commit f71d502 into vesoft-inc:master Apr 7, 2021
@critical27 critical27 deleted the cherry branch April 7, 2021 06:39
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* cherry pick vesoft-inc#431 from 2.0

* cherry pick vesoft-inc#424 from 2.0

Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants