Remove lock in FunctionManager (#2273)

Co-authored-by: trippli <[email protected]> Co-authored-by: dutor <[email protected]>
vesoft-inc · Aug 6, 2020 · 2249c03 · 2249c03
1 parent 28ddf2f
commit 2249c03
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/src/common/filter/FunctionManager.cpp b/src/common/filter/FunctionManager.cpp
@@ -566,7 +566,6 @@ FunctionManager::get(const std::string &func, size_t arity) {
 StatusOr<FunctionManager::Function>
 FunctionManager::getInternal(const std::string &func, size_t arity) const {
     auto status = Status::OK();
-    folly::RWSpinLock::ReadHolder holder(lock_);
     // check existence
     auto iter = functions_.find(func);
     if (iter == functions_.end()) {

diff --git a/src/common/filter/FunctionManager.h b/src/common/filter/FunctionManager.h
@@ -60,7 +60,6 @@ class FunctionManager final {
         Function                body_;
     };
 
-    mutable folly::RWSpinLock                           lock_;
     std::unordered_map<std::string, FunctionAttributes> functions_;
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -60,7 +60,6 @@ class FunctionManager final { @@
             Function                body_;
         };
-        mutable folly::RWSpinLock                           lock_;
         std::unordered_map<std::string, FunctionAttributes> functions_;
     };
@@ Expand Down @@