Remove lock in FunctionManager #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuguruogu
force-pushed
the
remove-function-mgr-lock
branch
from
694097f to
4d87ba4
Compare
dutor
approved these changes
Aug 5, 2020
|
But given your post of |
call function as filter with a little part of data returned. |
Shylock-Hg
reviewed
Aug 5, 2020
| @@ -60,7 +60,6 @@ class FunctionManager final { | |||
| Function body_; | |||
| }; | |||
|
|
|||
| mutable folly::RWSpinLock lock_; | |||
| std::unordered_map<std::string, FunctionAttributes> functions_; | |||
There was a problem hiding this comment.
I think you'd better mark it const.
There was a problem hiding this comment.
This may not help due to ref counter use atomic operation.
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
Co-authored-by: trippli <[email protected]> Co-authored-by: dutor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomic operation acts like dead lock, and can not go out of the while loop if multi-thread access it frequently.