Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast_primitive data type #354

Merged
merged 4 commits into from
Jun 14, 2024
Merged

fix: cast_primitive data type #354

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58a49d7
fix: cast_primitive data type
zhangweidev Jun 11, 2024
d47e871
ci: fix modern OS's docker compose version
wey-gu Jun 13, 2024
f6a49ac
ci: adapt new docker compose naming
wey-gu Jun 14, 2024
c21b05e
make linter happy
wey-gu Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/run_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ jobs:
run: pdm fmt-check
- name: Test with pytest
run: |
docker-compose -f tests/docker-compose.yaml up -d
docker compose -f tests/docker-compose.yaml up -d
sleep 20
pdm test
- name: Test SSL connection with pytest
run: |
enable_ssl=true docker-compose -f tests/docker-compose-ssl.yaml up -d
enable_ssl=true docker compose -f tests/docker-compose-ssl.yaml up -d
Copy link
Contributor

@wey-gu wey-gu Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest ubuntu 22.04 gh action runner comes with a different version of docker-compose, it failed here with docker-compose, but this fixed it. ref: https://askubuntu.com/questions/1508129/docker-compose-giving-containerconfig-errors-after-update-today

sleep 20
pdm test-ssl
- name: Upload Coverage to Codecov
Expand All @@ -101,7 +101,7 @@ jobs:
pip install prettytable pandas
- name: Setup containers
run: |
docker-compose -f tests/docker-compose.yaml up -d
docker compose -f tests/docker-compose.yaml up -d
sleep 20
- name: Test example
run: |
Expand Down
Loading