-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cast_primitive data type #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fix/contribution!
sleep 20 | ||
pdm test | ||
- name: Test SSL connection with pytest | ||
run: | | ||
enable_ssl=true docker-compose -f tests/docker-compose-ssl.yaml up -d | ||
enable_ssl=true docker compose -f tests/docker-compose-ssl.yaml up -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest ubuntu 22.04 gh action runner comes with a different version of docker-compose, it failed here with docker-compose
, but this fixed it. ref: https://askubuntu.com/questions/1508129/docker-compose-giving-containerconfig-errors-after-update-today
It's caused by the new compose container naming rule, fixing with d47e871
|
@@ -283,7 +283,7 @@ def test_remove_invalid_connection(): | |||
assert pool.init(addresses, configs) | |||
|
|||
# turn down one server('127.0.0.1', 9669) so the connection to it is invalid | |||
os.system("docker stop tests_graphd0_1") | |||
os.system("docker stop tests_graphd0_1 || docker stop tests-graphd0-1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new docker-compose comes with a different naming per container...
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 75.35% 75.27% -0.08%
==========================================
Files 19 19
Lines 2710 2710
==========================================
- Hits 2042 2040 -2
- Misses 668 670 +2 ☔ View full report in Codecov by Sentry. |
Only one line of change, other changes are due to github action runner change, caused docker-compose broken in Ubuntu 22.04. |
* fix: cast_primitive data type * ci: fix modern OS's docker compose version ref: https://askubuntu.com/questions/1508129/docker-compose-giving-containerconfig-errors-after-update-today * ci: adapt new docker compose naming * make linter happy --------- Co-authored-by: Wey Gu <[email protected]>
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
函数 cast_primitive 的 data 类型转换应该是 DVAL
How do you solve it?
DTVAL -> DVAL
Special notes for your reviewer, ex. impact of this fix, design document, etc: