[bug] Remove invalid connection from the idle queue when request new connection #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bug] 移除无效连接 ，防止由于无效连接导致 连接总数超出MaxConnPoolSize，导致创建session失败 Fail to create a new session from connection pool, username: root, password: nebula, failed to get connection: No valid connection in the idle queue and connection number has reached the pool capacity
Aiee
reviewed
Jul 28, 2022
Aiee
reviewed
Jul 28, 2022
connection_pool.go
Outdated
Comment on lines
154
to
155
| }else{ | ||
| tmpNextEle = ele.Next() |
There was a problem hiding this comment.
Good job. Please fix the format using go fmt.
Aiee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bug] 移除无效连接 ，防止由于无效连接导致 连接总数超出MaxConnPoolSize，导致创建session失败
Fail to create a new session from connection pool, username: xxx, password: xxxx, failed to get connection: No valid connection in the idle queue and connection number has reached the pool capacity