[bug] Remove invalid connection from the idle queue when request new …

…connection (#214) * [bug] 无效连接总数超出MaxConnPoolSize，创建session失败 [bug] 移除无效连接，防止由于无效连接导致连接总数超出MaxConnPoolSize，导致创建session失败 Fail to create a new session from connection pool, username: root, password: nebula, failed to get connection: No valid connection in the idle queue and connection number has reached the pool capacity * [fix] go fmt Co-authored-by: lopn <[email protected]>
vesoft-inc · Jul 28, 2022 · e8bbdaa · e8bbdaa
1 parent f0f241c
commit e8bbdaa
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/connection_pool.go b/connection_pool.go
@@ -144,12 +144,16 @@ func (pool *ConnectionPool) getIdleConn() (*connection, error) {
 	if pool.idleConnectionQueue.Len() > 0 {
 		var newConn *connection = nil
 		var newEle *list.Element = nil
-		for ele := pool.idleConnectionQueue.Front(); ele != nil; ele = ele.Next() {
+		var tmpNextEle *list.Element = nil
+		for ele := pool.idleConnectionQueue.Front(); ele != nil; ele = tmpNextEle {
 			// Check if connection is valid
 			if res := ele.Value.(*connection).ping(); res {
 				newConn = ele.Value.(*connection)
 				newEle = ele
 				break
+			} else {
+				tmpNextEle = ele.Next()
+				pool.idleConnectionQueue.Remove(ele)
 			}
 		}
 		if newConn == nil {