Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tests with latest versions of go #206

Merged
merged 7 commits into from
Jul 1, 2022

Conversation

peczenyj
Copy link
Contributor

@peczenyj peczenyj commented May 10, 2022

I hope this will work, I enable tests using go versions 1.17 and 1.18 into github workflow test.yml

this is related to issue #199 and it is only possible because #200

I think we can remove support to go 1.13 since it is deprecated.

Copy link
Contributor

@veezhang veezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wey-gu wey-gu requested a review from Aiee July 1, 2022 10:00
@wey-gu
Copy link
Contributor

wey-gu commented Jul 1, 2022

@Aiee could you please help review this, too :D? Thanks!

@Aiee Aiee merged commit 2f85fa9 into vesoft-inc:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants