-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove remote services, the code is not necessary to use this project as a nebula driver #200
Conversation
… as a nebula driver
Hello @peczenyj, you are right that these files are not necessary to be there. Since the parent directories of these files contain only 1 file, maybe you can delete the directory as well to make it cleaner. |
I love this....
Thanks a ton, @peczenyj ! |
Cleaned and Rebased |
* add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job!
… as a nebula driver (vesoft-inc#200) * remove remote services, the code is not necessary to use this project as a nebula driver * Create integration tests (vesoft-inc#201) * add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results Co-authored-by: Yichen Wang <[email protected]>
* update test to check ipv6 version of localhost * use net.JoinHostPort to handle the ipv6 case properly * remove remote services, the code is not necessary to use this project as a nebula driver (#200) * remove remote services, the code is not necessary to use this project as a nebula driver * Create integration tests (#201) * add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: Yichen Wang <[email protected]>
Hello
this patch should fix issue #199
as you can see, each deleted file is a specific program with a main function.
it is not necessary for this project IMHO
Best Regards
Tiago