This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Refactor the build system #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dutor
commented
Aug 8, 2020
•
dutor
commented
- Extract the common CMake scripts into nebula-common
- Group CMake scripts according to their purposes.
- Automatically install third party if not present.
- Fix warning on parallel jobs of sub-make
dutor
requested review from
monadbobo,
yixinglu,
CPWstatic,
Shylock-Hg and
laura-ding
This was referenced Aug 8, 2020
yixinglu
reviewed
Aug 10, 2020
yixinglu
previously approved these changes
Aug 10, 2020
laura-ding
reviewed
Aug 10, 2020
laura-ding
approved these changes
Aug 10, 2020
yixinglu
approved these changes
Aug 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.