Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade marked from 0.7.0 to 1.1.1 #377

Closed
wants to merge 11 commits into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • core/readme/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
medium severity Regular Expression Denial of Service (ReDoS )
SNYK-JS-MARKED-584281
Yes No Known Exploit
Commit messages
Package name: marked The new version differs by 250 commits.
  • 1ad8e69 Merge pull request #1731 from UziTech/release-1.1.1
  • 7e17526 1.1.1
  • 7fbee6e Merge pull request #1730 from UziTech/update-deps
  • 6f7522f Merge pull request #1729 from UziTech/quick-ref
  • f8024eb remove ending slash
  • 524ae66 remove ending slash
  • 0d6e056 build
  • 04ac593 update dev deps
  • f36f676 🗜️ build [skip ci]
  • dddf9ae Merge pull request #1686 from calculuschild/EmphasisFixes
  • 6b729ed Merge branch 'EmphasisFixes' of https://github.com/calculuschild/marked into EmphasisFixes
  • e27e6f9 Sorted strong and em into sub-objects
  • a761316 Merge pull request #1726 from UziTech/show-rules
  • f8193ed add npm run rules
  • ad720c1 Make emEnd const
  • 1fb141d Make strEnd const
  • 226bbe7 Lint
  • cc778ad Removed redundancy in "startEM" check
  • 211b9f9 Removed Lookbehinds
  • 982b57e Merge pull request #1720 from vassudanagunta/docs-patch-1
  • 2a847e6 clarify level of support for Markdown flavors
  • bd4f8c4 Fix unrestricted "any character" for REDOS
  • 4e7902e Gaaaah lint
  • 4db32dc Links are masked only once per inline string

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

@DanielRuf
Copy link
Contributor

Rerunning CI jobs to see if we can get all running.

@DanielRuf
Copy link
Contributor

I guess we are not affected by the breaking changes from 1.0.0: https://github.com/markedjs/marked/releases

@juanpicado
Copy link
Member

I'd need to update manually, our master branch here 9.x. :(

@juanpicado juanpicado changed the base branch from master to 9.x July 30, 2020 19:06
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #377 into 9.x will increase coverage by 10.73%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##              9.x     #377       +/-   ##
===========================================
+ Coverage   68.14%   78.87%   +10.73%     
===========================================
  Files          29        7       -22     
  Lines        1400      445      -955     
  Branches      204       74      -130     
===========================================
- Hits          954      351      -603     
+ Misses        406       53      -353     
- Partials       40       41        +1     
Flag Coverage Δ
#core 86.36% <100.00%> (ø)
#plugins 78.05% <89.47%> (+11.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/local-storage/src/local-fs.ts 80.98% <88.88%> (-6.75%) ⬇️
core/file-locking/src/lockfile.ts 100.00% <100.00%> (ø)
core/file-locking/src/readFile.ts 82.35% <100.00%> (-5.89%) ⬇️
core/file-locking/src/unclock.ts 100.00% <100.00%> (ø)
plugins/local-storage/src/local-database.ts 71.25% <100.00%> (-14.38%) ⬇️
plugins/auth-memory/src/Memory.ts 84.74% <0.00%> (-5.09%) ⬇️
plugins/google-cloud/src/storage-helper.ts
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461e008...3d5cfcb. Read the comment docs.

@juanpicado juanpicado closed this Aug 28, 2020
@juanpicado juanpicado deleted the snyk-fix-1c980e880f42def3258dc56e102c6585 branch August 28, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants