Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools dependencies and improve their readmes #350

Merged
merged 2 commits into from
Mar 28, 2020

Conversation

sergiohgz
Copy link
Member

Type: chore
Scope: tools

The following has been addressed in the PR:

  • There is a related issue? No
  • Unit or Functional tests are included in the PR No

Description: Update monorepo and tools packages dependencies, apply Prettier v2 changes and add more detail to README file in each tools project

@sergiohgz sergiohgz added tool Tool package dependencies Pull requests that update a dependency file labels Mar 26, 2020
@sergiohgz sergiohgz requested a review from a team March 26, 2020 21:11
@sergiohgz sergiohgz self-assigned this Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #350 into master will not change coverage by %.
The diff coverage is 95.34%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   68.14%   68.14%           
=======================================
  Files          29       29           
  Lines        1400     1400           
  Branches      204      203    -1     
=======================================
  Hits          954      954           
  Misses        406      406           
  Partials       40       40           
Flag Coverage Δ
#core 86.36% <100.00%> (ø)
#plugins 66.42% <93.10%> (ø)
Impacted Files Coverage Δ
plugins/aws-s3-storage/src/s3PackageManager.ts 42.94% <ø> (ø)
plugins/local-storage/src/local-fs.ts 87.73% <88.88%> (ø)
core/file-locking/src/lockfile.ts 100.00% <100.00%> (ø)
core/file-locking/src/readFile.ts 88.23% <100.00%> (ø)
core/file-locking/src/unclock.ts 100.00% <100.00%> (ø)
core/file-locking/src/utils.ts 82.60% <100.00%> (ø)
core/streams/src/index.ts 93.33% <100.00%> (ø)
plugins/google-cloud/src/storage.ts 44.13% <100.00%> (ø)
plugins/htpasswd/src/utils.ts 74.24% <100.00%> (ø)
plugins/local-storage/src/local-database.ts 85.62% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd08aa...3882a2d. Read the comment docs.

@@ -51,8 +51,7 @@
},
"lint-staged": {
"**/*.{js,ts}": [
"eslint --fix",
"git add"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we remove "git add" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main breaking change lint-staged added in v10

juanpicado
juanpicado previously approved these changes Mar 28, 2020
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , check my comments before merge 💯

BREAKING CHANGE New minimum Node version supported is 10.x. Also, new Prettier minimum version is 2.0.2
@sergiohgz sergiohgz merged commit 1604e13 into master Mar 28, 2020
@sergiohgz sergiohgz deleted the update-dependencies branch March 28, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tool Tool package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants