Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deleting Go code #6956

Merged
merged 8 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
37 changes: 0 additions & 37 deletions .github/actions/setup-go/action.yml

This file was deleted.

20 changes: 15 additions & 5 deletions .github/actions/setup-turborepo-environment/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ runs:
with:
extra-flags: --no-optional

- name: "Setup Go"
uses: ./.github/actions/setup-go
with:
github-token: ${{ inputs.github-token }}

- name: "Setup Rust"
uses: ./.github/actions/setup-rust
with:
Expand All @@ -30,6 +25,21 @@ runs:
cache-key: ${{ inputs.target }}
save-cache: true

- name: Set Up Protoc
id: set-up-protoc
continue-on-error: true
uses: arduino/[email protected]
with:
version: "3.x"
repo-token: ${{ inputs.github-token }}

- name: Set Up Protoc (second try)
if: steps.set-up-protoc.outcome == 'failure'
uses: arduino/[email protected]
with:
version: "3.x"
repo-token: ${{ inputs.github-token }}

- name: "Setup capnproto"
uses: ./.github/actions/setup-capnproto

Expand Down
56 changes: 28 additions & 28 deletions .github/workflows/bench-turbopack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,11 @@ jobs:
needs.determine_jobs.outputs.cargo_only == 'true'
name: Turbopack rust check
runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
- "self-hosted"
- "linux"
- "x64"
- "metal"

steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -139,11 +139,6 @@ jobs:
components: clippy
targets: wasm32-unknown-unknown

- name: Setup Go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing protoc needs to be added back here

uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Run cargo check release
run: |
RUSTFLAGS="-D warnings -A deprecated" cargo groups check turbopack --features rustls-tls --release
Expand Down Expand Up @@ -188,22 +183,17 @@ jobs:
TURBOPACK_BENCH_COUNTS: 1000,10000

runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
- "self-hosted"
- "linux"
- "x64"
- "metal"

name: Benchmark on ${{ matrix.bench.name }}

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing protoc needs to be added back here

uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Setup Node.js
uses: ./.github/actions/setup-node

Expand Down Expand Up @@ -328,10 +318,10 @@ jobs:
title: Linux
quiet: false
runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
- "self-hosted"
- "linux"
- "x64"
- "metal"
# - name: macos
# title: MacOS
# quiet: true
Expand All @@ -352,11 +342,6 @@ jobs:
- name: Fetch the base branch
run: git -c protocol.version=2 fetch --no-tags --progress --no-recurse-submodules --depth=1 origin +${{ github.base_ref }}:base

- name: Setup Go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing protoc needs to be added back here

uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Setup Node.js
uses: ./.github/actions/setup-node

Expand All @@ -365,6 +350,21 @@ jobs:
with:
shared-cache-key: benchmark-${{ matrix.os.name }}

- name: Set Up Protoc
id: set-up-protoc
continue-on-error: true
uses: arduino/[email protected]
with:
version: "3.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Set Up Protoc (second try)
if: steps.set-up-protoc.outcome == 'failure'
uses: arduino/[email protected]
with:
version: "3.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Benchmark and compare with base branch
uses: sokra/criterion-compare-action@main
timeout-minutes: 30
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/bench-turborepo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup-node
- uses: ./.github/actions/setup-go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing protoc needs to be added back here

with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- uses: ./.github/actions/setup-turborepo-environment
with:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/bench-turbotrace-against-node-nft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ jobs:

- uses: ./.github/actions/setup-rust

- uses: ./.github/actions/setup-go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing protoc needs to be added back here

with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Install hoisted npm dependencies
working-directory: crates/turbopack/tests/node-file-trace
run: |
Expand Down
16 changes: 13 additions & 3 deletions .github/workflows/test-turbopack-rust-bench-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,20 @@ jobs:
with:
save-cache: true

- name: Setup Go
uses: ./.github/actions/setup-go
- name: Set Up Protoc
id: set-up-protoc
continue-on-error: true
uses: arduino/[email protected]
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
version: "3.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Set Up Protoc (second try)
if: steps.set-up-protoc.outcome == 'failure'
uses: arduino/[email protected]
with:
version: "3.x"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Setup Node.js
uses: ./.github/actions/setup-node
Expand Down
Loading
Loading