-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deleting Go code #6956
Changes from 6 commits
4f12b29
089c937
072965c
885ac75
7fc7351
c9f7f53
0e6d44f
d320ca4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,11 +17,6 @@ runs: | |
with: | ||
extra-flags: --no-optional | ||
|
||
- name: "Setup Go" | ||
uses: ./.github/actions/setup-go | ||
with: | ||
github-token: ${{ inputs.github-token }} | ||
|
||
- name: "Setup Rust" | ||
uses: ./.github/actions/setup-rust | ||
with: | ||
|
@@ -30,6 +25,21 @@ runs: | |
cache-key: ${{ inputs.target }} | ||
save-cache: true | ||
|
||
- name: Set Up Protoc | ||
id: set-up-protoc | ||
continue-on-error: true | ||
uses: arduino/[email protected] | ||
with: | ||
version: "3.x" | ||
repo-token: ${{ inputs.github-token }} | ||
|
||
- name: Set Up Protoc (second try) | ||
if: steps.set-up-protoc.outcome == 'failure' | ||
uses: arduino/[email protected] | ||
with: | ||
version: "3.x" | ||
repo-token: ${{ inputs.github-token }} | ||
|
||
- name: "Setup capnproto" | ||
uses: ./.github/actions/setup-capnproto | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,11 +124,11 @@ jobs: | |
needs.determine_jobs.outputs.cargo_only == 'true' | ||
name: Turbopack rust check | ||
runs-on: | ||
- 'self-hosted' | ||
- 'linux' | ||
- 'x64' | ||
- 'metal' | ||
- "self-hosted" | ||
- "linux" | ||
- "x64" | ||
- "metal" | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
@@ -139,11 +139,6 @@ jobs: | |
components: clippy | ||
targets: wasm32-unknown-unknown | ||
|
||
- name: Setup Go | ||
uses: ./.github/actions/setup-go | ||
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
|
||
- name: Run cargo check release | ||
run: | | ||
RUSTFLAGS="-D warnings -A deprecated" cargo groups check turbopack --features rustls-tls --release | ||
|
@@ -188,22 +183,17 @@ jobs: | |
TURBOPACK_BENCH_COUNTS: 1000,10000 | ||
|
||
runs-on: | ||
- 'self-hosted' | ||
- 'linux' | ||
- 'x64' | ||
- 'metal' | ||
- "self-hosted" | ||
- "linux" | ||
- "x64" | ||
- "metal" | ||
|
||
name: Benchmark on ${{ matrix.bench.name }} | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Installing protoc needs to be added back here |
||
uses: ./.github/actions/setup-go | ||
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
|
||
- name: Setup Node.js | ||
uses: ./.github/actions/setup-node | ||
|
||
|
@@ -328,10 +318,10 @@ jobs: | |
title: Linux | ||
quiet: false | ||
runs-on: | ||
- 'self-hosted' | ||
- 'linux' | ||
- 'x64' | ||
- 'metal' | ||
- "self-hosted" | ||
- "linux" | ||
- "x64" | ||
- "metal" | ||
# - name: macos | ||
# title: MacOS | ||
# quiet: true | ||
|
@@ -352,11 +342,6 @@ jobs: | |
- name: Fetch the base branch | ||
run: git -c protocol.version=2 fetch --no-tags --progress --no-recurse-submodules --depth=1 origin +${{ github.base_ref }}:base | ||
|
||
- name: Setup Go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Installing protoc needs to be added back here |
||
uses: ./.github/actions/setup-go | ||
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
|
||
- name: Setup Node.js | ||
uses: ./.github/actions/setup-node | ||
|
||
|
@@ -365,6 +350,21 @@ jobs: | |
with: | ||
shared-cache-key: benchmark-${{ matrix.os.name }} | ||
|
||
- name: Set Up Protoc | ||
id: set-up-protoc | ||
continue-on-error: true | ||
uses: arduino/[email protected] | ||
with: | ||
version: "3.x" | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Set Up Protoc (second try) | ||
if: steps.set-up-protoc.outcome == 'failure' | ||
uses: arduino/[email protected] | ||
with: | ||
version: "3.x" | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Benchmark and compare with base branch | ||
uses: sokra/criterion-compare-action@main | ||
timeout-minutes: 30 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,9 +24,6 @@ jobs: | |
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: ./.github/actions/setup-node | ||
- uses: ./.github/actions/setup-go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Installing protoc needs to be added back here |
||
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
|
||
- uses: ./.github/actions/setup-turborepo-environment | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,10 +32,6 @@ jobs: | |
|
||
- uses: ./.github/actions/setup-rust | ||
|
||
- uses: ./.github/actions/setup-go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Installing protoc needs to be added back here |
||
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
|
||
- name: Install hoisted npm dependencies | ||
working-directory: crates/turbopack/tests/node-file-trace | ||
run: | | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,10 +33,20 @@ jobs: | |
with: | ||
save-cache: true | ||
|
||
- name: Setup Go | ||
uses: ./.github/actions/setup-go | ||
- name: Set Up Protoc | ||
id: set-up-protoc | ||
continue-on-error: true | ||
uses: arduino/[email protected] | ||
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
version: "3.x" | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Set Up Protoc (second try) | ||
if: steps.set-up-protoc.outcome == 'failure' | ||
uses: arduino/[email protected] | ||
with: | ||
version: "3.x" | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Setup Node.js | ||
uses: ./.github/actions/setup-node | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing protoc needs to be added back here