-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deleting Go code #6956
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
319cab0
to
c2c1ce2
Compare
✅ This change can build |
|
015fecc
to
7829c5f
Compare
7829c5f
to
ac23f79
Compare
184c470
to
05e7470
Compare
I think this line needs to get cut: https://github.com/vercel/turbo/blob/main/cli/scripts/npm-native-packages/npm-native-packages.js#L54 |
c32548b
to
885ac75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
cli/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're keeping cli/
as a package?
@@ -139,11 +139,6 @@ jobs: | |||
components: clippy | |||
targets: wasm32-unknown-unknown | |||
|
|||
- name: Setup Go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing protoc needs to be added back here
|
||
name: Benchmark on ${{ matrix.bench.name }} | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing protoc needs to be added back here
@@ -352,11 +342,6 @@ jobs: | |||
- name: Fetch the base branch | |||
run: git -c protocol.version=2 fetch --no-tags --progress --no-recurse-submodules --depth=1 origin +${{ github.base_ref }}:base | |||
|
|||
- name: Setup Go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing protoc needs to be added back here
@@ -24,9 +24,6 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v3 | |||
- uses: ./.github/actions/setup-node | |||
- uses: ./.github/actions/setup-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing protoc needs to be added back here
@@ -32,10 +32,6 @@ jobs: | |||
|
|||
- uses: ./.github/actions/setup-rust | |||
|
|||
- uses: ./.github/actions/setup-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing protoc needs to be added back here
### Description Our error printing was a little wonky with some stuttering due to old Go behavior. With #6956 merged we can now clean this up ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2190 --------- Co-authored-by: Chris Olszewski <[email protected]>
### Description LFG ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2011
### Description LFG ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2011
### Description LFG ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2011
Description
LFG
Testing Instructions
Closes TURBO-2011