refactor: Deleting Go code #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
nicholasyang/delete-go
branch
from
319cab0
to
c2c1ce2
Compare
|
✅ This change can build |
|
NicholasLYang
force-pushed
the
nicholasyang/delete-go
branch
from
015fecc
to
7829c5f
Compare
NicholasLYang
force-pushed
the
nicholasyang/delete-go
branch
from
7829c5f
to
ac23f79
Compare
NicholasLYang
force-pushed
the
nicholasyang/delete-go
branch
from
184c470
to
05e7470
Compare
|
I think this line needs to get cut: https://github.com/vercel/turbo/blob/main/cli/scripts/npm-native-packages/npm-native-packages.js#L54 |
NicholasLYang
force-pushed
the
nicholasyang/delete-go
branch
from
c32548b
to
885ac75
Compare
mehulkar
approved these changes
Jan 30, 2024
cli/package.json
Outdated
There was a problem hiding this comment.
we're keeping cli/ as a package?
chris-olszewski
requested changes
Jan 30, 2024
| @@ -139,11 +139,6 @@ jobs: | |||
| components: clippy | |||
| targets: wasm32-unknown-unknown | |||
|
|
|||
| - name: Setup Go | |||
There was a problem hiding this comment.
Installing protoc needs to be added back here
|
|
||
| name: Benchmark on ${{ matrix.bench.name }} | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Go |
There was a problem hiding this comment.
Installing protoc needs to be added back here
| @@ -352,11 +342,6 @@ jobs: | |||
| - name: Fetch the base branch | |||
| run: git -c protocol.version=2 fetch --no-tags --progress --no-recurse-submodules --depth=1 origin +${{ github.base_ref }}:base | |||
|
|
|||
| - name: Setup Go | |||
There was a problem hiding this comment.
Installing protoc needs to be added back here
| @@ -24,9 +24,6 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: ./.github/actions/setup-node | |||
| - uses: ./.github/actions/setup-go | |||
There was a problem hiding this comment.
Installing protoc needs to be added back here
| @@ -32,10 +32,6 @@ jobs: | |||
|
|
|||
| - uses: ./.github/actions/setup-rust | |||
|
|
|||
| - uses: ./.github/actions/setup-go | |||
There was a problem hiding this comment.
Installing protoc needs to be added back here
chris-olszewski
approved these changes
Jan 30, 2024
NicholasLYang
added a commit
that referenced
this pull request
Feb 2, 2024
### Description Our error printing was a little wonky with some stuttering due to old Go behavior. With #6956 merged we can now clean this up ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2190 --------- Co-authored-by: Chris Olszewski <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description LFG ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2011
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description LFG ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2011
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description LFG ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LFG
Testing Instructions
Closes TURBO-2011