Remove EnvironmentIntention #5420

alexkirsz · 2023-06-29T08:38:25Z

Description

This PR removes the EnvironmentIntention enum entirely. The enum wasn't being used anywhere and created artificial differences between environments that weren't useful (nor respected in some cases).

Next.js PR: vercel/next.js#51965

Testing Instructions

CI

vercel · 2023-06-29T08:38:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-cra-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 30, 2023 0:36am

10 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Jun 30, 2023 0:36am

github-actions · 2023-06-29T08:39:46Z

⚠️ This change may fail to build next-swc.

Logs

packages/next-swc/crates/next-core/src/app_source.rs:35:17: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::dev_server::source::specificity`
packages/next-swc/crates/next-core/src/manifest.rs:17:71: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::dev_server::source::ContentSourceResultVc`
packages/next-swc/crates/next-core/src/next_image/content_source.rs:17:13: �[38;5;9merror[E0432]: unresolved imports `turbopack_binding::turbopack::dev_server::source::wrapping_source::encode_pathname_to_url`, `turbopack_binding::turbopack::dev_server::source::wrapping_source::WrappedContentSourceVc`, `turbopack_binding::turbopack::dev_server::source::ContentSourceResultVc`, `turbopack_binding::turbopack::dev_server::source::NeededData`
packages/next-swc/crates/next-core/src/page_source.rs:29:17: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::dev_server::source::specificity`
packages/next-swc/crates/next-core/src/pages_structure.rs:5:36: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::dev_server::source::specificity`
packages/next-swc/crates/next-core/src/router_source.rs:12:9: �[38;5;9merror[E0432]: unresolved imports `turbopack_binding::turbopack::dev_server::source::ContentSourceResultVc`, `turbopack_binding::turbopack::dev_server::source::NeededData`
packages/next-swc/crates/next-core/src/manifest.rs:154:1: �[38;5;9merror[E0407]: method `get` is not a member of trait `ContentSource`
packages/next-swc/crates/next-core/src/next_image/content_source.rs:42:1: �[38;5;9merror[E0407]: method `get` is not a member of trait `ContentSource`
packages/next-swc/crates/next-core/src/router_source.rs:89:1: �[38;5;9merror[E0407]: method `get` is not a member of trait `ContentSource`
packages/next-swc/crates/next-core/src/app_source.rs:674:24: �[38;5;9merror[E0277]: the trait bound `FileSystemPathVc: From<NextParamsMatcherVc>` is not satisfied
packages/next-swc/crates/next-core/src/app_source.rs:687:10: �[38;5;9merror[E0277]: the trait bound `StringVc: From<AppRendererVc>` is not satisfied
packages/next-swc/crates/next-core/src/app_source.rs:669:18: �[38;5;9merror[E0061]: this function takes 11 arguments but 10 arguments were supplied
packages/next-swc/crates/next-core/src/app_source.rs:718:38: �[38;5;9merror[E0277]: the trait bound `FileSystemPathVc: From<NextFallbackMatcherVc>` is not satisfied
packages/next-swc/crates/next-core/src/app_source.rs:731:10: �[38;5;9merror[E0277]: the trait bound `StringVc: From<AppRendererVc>` is not satisfied
packages/next-swc/crates/next-core/src/app_source.rs:713:18: �[38;5;9merror[E0061]: this function takes 11 arguments but 10 arguments were supplied
packages/next-swc/crates/next-core/src/app_source.rs:763:24: �[38;5;9merror[E0277]: the trait bound `FileSystemPathVc: From<NextParamsMatcherVc>` is not satisfied
packages/next-swc/crates/next-core/src/app_source.rs:776:10: �[38;5;9merror[E0277]: the trait bound `StringVc: From<AppRouteVc>` is not satisfied
packages/next-swc/crates/next-core/src/app_source.rs:758:18: �[38;5;9merror[E0061]: this function takes 10 arguments but 9 arguments were supplied
packages/next-swc/crates/next-core/src/manifest.rs:154:1: �[38;5;9merror[E0046]: not all trait items implemented, missing: `get_routes`
packages/next-swc/crates/next-core/src/next_image/content_source.rs:102:26: �[38;5;9merror[E0599]: no method named `content_source` found for struct `RewriteBuilder` in the current scope
packages/next-swc/crates/next-core/src/next_image/content_source.rs:42:1: �[38;5;9merror[E0046]: not all trait items implemented, missing: `get_routes`
packages/next-swc/crates/next-core/src/page_source.rs:411:27: �[38;5;9merror[E0277]: the trait bound `FileSystemPathVc: From<NextParamsMatcherVc>` is not satisfied
packages/next-swc/crates/next-core/src/page_source.rs:424:14: �[38;5;9merror[E0277]: the trait bound `StringVc: From<SsrEntryVc>` is not satisfied
packages/next-swc/crates/next-core/src/page_source.rs:406:9: �[38;5;9merror[E0061]: this function takes 10 arguments but 9 arguments were supplied
packages/next-swc/crates/next-core/src/page_source.rs:465:31: �[38;5;9merror[E0277]: the trait bound `FileSystemPathVc: From<NextParamsMatcherVc>` is not satisfied
packages/next-swc/crates/next-core/src/page_source.rs:444:10: �[38;5;9merror[E0277]: the trait bound `StringVc: From<SsrEntryVc>` is not satisfied
packages/next-swc/crates/next-core/src/page_source.rs:460:13: �[38;5;9merror[E0061]: this function takes 11 arguments but 10 arguments were supplied
packages/next-swc/crates/next-core/src/page_source.rs:477:36: �[38;5;9merror[E0277]: the trait bound `FileSystemPathVc: From<NextPrefixSuffixParamsMatcherVc>` is not satisfied
packages/next-swc/crates/next-core/src/page_source.rs:457:10: �[38;5;9merror[E0277]: the trait bound `StringVc: From<SsrEntryVc>` is not satisfied
packages/next-swc/crates/next-core/src/page_source.rs:472:13: �[38;5;9merror[E0061]: this function takes 11 arguments but 10 arguments were supplied
packages/next-swc/crates/next-core/src/page_source.rs:577:6: �[38;5;9merror[E0277]: the trait bound `StringVc: From<SsrEntryVc>` is not satisfied
packages/next-swc/crates/next-core/src/page_source.rs:588:9: �[38;5;9merror[E0061]: this function takes 11 arguments but 10 arguments were supplied
packages/next-swc/crates/next-core/src/router_source.rs:105:18: �[38;5;9merror[E0599]: no method named `get` found for struct `ContentSourceVc` in the current scope
packages/next-swc/crates/next-core/src/router_source.rs:156:18: �[38;5;9merror[E0599]: no method named `get` found for struct `ContentSourceVc` in the current scope
packages/next-swc/crates/next-core/src/router_source.rs:158:73: �[38;5;9merror[E0599]: no method named `content_source` found for struct `RewriteBuilder` in the current scope
packages/next-swc/crates/next-core/src/router_source.rs:89:1: �[38;5;9merror[E0046]: not all trait items implemented, missing: `get_routes`
error: could not compile `next-core` (lib) due to 36 previous errors

See job summary for details

github-actions · 2023-06-29T08:57:14Z

🟢 CI successful 🟢

Thanks

github-actions · 2023-06-29T09:04:12Z

Linux Benchmark for `aafd59e`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5840.87µs ± 18.89µs	5770.46µs ± 33.49µs	-1.21%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5424.80µs ± 25.78µs	5574.42µs ± 139.74µs	+2.76%
bench_startup/Turbopack CSR/1000 modules	904.39ms ± 2.90ms	902.87ms ± 3.38ms	-0.17%

sokra

examples need some update, otherwise fine

github-actions · 2023-06-30T12:55:40Z

Linux Benchmark for 765b073

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.68ms ± 0.05ms	10.72ms ± 0.08ms	+0.37%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9701.42µs ± 76.38µs	9832.12µs ± 109.98µs	+1.35%
bench_startup/Turbopack CSR/1000 modules	1103.09ms ± 0.69ms	1111.48ms ± 4.92ms	+0.76%

github-actions · 2023-06-30T13:25:56Z

MacOS Benchmark for 765b073

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	3447.28ms ± 63.57ms	13.79s ± 2.95s	+300.03%	+120.76%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.22ms ± 0.08ms	28.31ms ± 0.10ms	+0.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules	27.64ms ± 0.14ms	27.39ms ± 0.10ms	-0.92%
bench_startup/Turbopack CSR/1000 modules	3447.28ms ± 63.57ms	13.79s ± 2.95s	+300.03%	+120.76%

See vercel/turborepo#5420 # Turbopack changes * vercel/turborepo#5420 * vercel/turborepo#5387

### Description This PR removes the `EnvironmentIntention` enum entirely. The enum wasn't being used anywhere and created artificial differences between environments that weren't useful (nor respected in some cases). Next.js PR: #51965 ### Testing Instructions CI

alexkirsz requested a review from a team as a code owner June 29, 2023 08:38

turbo-orchestrator bot added the team: turbopack label Jun 29, 2023

Remove EnvironmentIntention

24e6769

alexkirsz force-pushed the alexkirsz/web-1247-get-rid-of-environmentintention branch from 8d79473 to 24e6769 Compare June 29, 2023 08:44

alexkirsz mentioned this pull request Jun 29, 2023

Remove EnvironmentIntention vercel/next.js#51965

Merged

sokra approved these changes Jun 29, 2023

View reviewed changes

Update examples

10d88ec

sokra approved these changes Jun 30, 2023

View reviewed changes

alexkirsz merged commit dfffb3c into main Jun 30, 2023

alexkirsz deleted the alexkirsz/web-1247-get-rid-of-environmentintention branch June 30, 2023 14:01

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jul 3, 2023

Remove EnvironmentIntention (#51965)

805bfa4

See vercel/turborepo#5420 # Turbopack changes * vercel/turborepo#5420 * vercel/turborepo#5387

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove EnvironmentIntention #5420

Remove EnvironmentIntention #5420

alexkirsz commented Jun 29, 2023 •

edited

Loading

vercel bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023

sokra left a comment

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

Remove EnvironmentIntention #5420

Remove EnvironmentIntention #5420

Conversation

alexkirsz commented Jun 29, 2023 • edited Loading

Description

Testing Instructions

vercel bot commented Jun 29, 2023 • edited Loading

github-actions bot commented Jun 29, 2023 • edited Loading

github-actions bot commented Jun 29, 2023 • edited Loading

🟢 CI successful 🟢

github-actions bot commented Jun 29, 2023

Linux Benchmark for aafd59e

sokra left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 30, 2023

Linux Benchmark for 765b073

github-actions bot commented Jun 30, 2023

MacOS Benchmark for 765b073

alexkirsz commented Jun 29, 2023 •

edited

Loading

vercel bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

Linux Benchmark for `aafd59e`