Mark Vcs as must-use
#5387
Merged
Mark Vcs as must-use
#5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the `#[must-use]` macro [0] to mark Vcs as needing to be used when created. The compiler creates warnings for each case. Test Plan: Create a Vc in code and verify a warning is shown when Turbopack is built. [0] https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
Linux Benchmark for 900d4c9Click to view benchmark
|
ForsakenHarmony
approved these changes
Jun 26, 2023
jridgewell
suggested changes
Jun 26, 2023
MacOS Benchmark for 900d4c9
Click to view full benchmark
|
sokra
reviewed
Jun 27, 2023
| my_transitive_emitting_function("", "a"); | ||
| my_transitive_emitting_function("", "b"); | ||
| async fn my_multi_emitting_function() -> Result<ThingVc> { | ||
| my_transitive_emitting_function("", "a").await?; |
sokra
reviewed
Jun 27, 2023
crates/turbopack/src/lib.rs
Outdated
| @@ -435,7 +435,7 @@ impl AssetContext for ModuleAssetContext { | |||
| request, | |||
| ); | |||
|
|
|||
| result.add_reference(types_reference.into()); | |||
| result.add_reference(types_reference.into()).await?; | |||
There was a problem hiding this comment.
This probably returns a new result. Maybe rename the function to with_reference
Suggested change
| result.add_reference(types_reference.into()).await?; | |
| result = result.add_reference(types_reference.into()); |
Linux Benchmark for 70a6270Click to view benchmark
|
jridgewell
approved these changes
Jun 29, 2023
| sig.span() | ||
| .unwrap() | ||
| .error( | ||
| "Cannot return `()` from a turbo_tasks function. Return Result<NothingVc> instead.", |
There was a problem hiding this comment.
Suggested change
| "Cannot return `()` from a turbo_tasks function. Return Result<NothingVc> instead.", | |
| "Cannot return `()` from a turbo_tasks function. Return a NothingVc instead.", |
Linux Benchmark for 84f15d3Click to view benchmark
|
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 3, 2023
See vercel/turborepo#5420 # Turbopack changes * vercel/turborepo#5420 * vercel/turborepo#5387
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This uses the `#[must-use]` macro [0] to mark Vcs as needing to be used when created. The compiler creates warnings for each case. Test Plan: Create a Vc in code and verify a warning is shown when Turbopack is built. [0] https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This uses the `#[must-use]` macro [0] to mark Vcs as needing to be used when created. The compiler creates warnings for each case. Test Plan: Create a Vc in code and verify a warning is shown when Turbopack is built. [0] https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
This uses the `#[must-use]` macro [0] to mark Vcs as needing to be used when created. The compiler creates warnings for each case. Test Plan: Create a Vc in code and verify a warning is shown when Turbopack is built. [0] https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
#[must-use]macro [0] to mark Vcs as needing to be used when created. The compiler creates warnings for each case.Test Plan: Create a Vc in code and verify a warning is shown when Turbopack is built.
[0] https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute