code fixed that redefines the response.end as async at with-passport-and-next-connect #51628 #54400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: documentation
examples
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority |
|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
styfle
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Where is the error message linked to?
styfle
reviewed
Aug 22, 2023
| if (res.finished || res.writableEnded || res.headersSent) return | ||
| if (cookieOpts.maxAge) { | ||
| req.session.maxAge = cookieOpts.maxAge | ||
| } | ||
|
|
||
| const token = await createLoginSession(req.session, secret) | ||
| const token = createLoginSession(req.session, secret) |
There was a problem hiding this comment.
This looks like a bug.
The await is necessary since the function is async as seen here:
|
Closing as stale 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endfunction as async #51628