-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
with-passport-and-next-connect redefines response end
function as async
#51628
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
I sorts of explained this option in my initial report, the problem is that the example relies on |
Lets do this.... Assign this to me. |
I am new to open source. Please let me know if this has been resolved or not. Also if possible give me a brief about the issue. So that i can resolve it. Any help would be appreciated. |
Can i get a brief about this issue? |
I am able to reproduce this when i am sending a GET request to api/login. |
…ion and Handle session asynchronously before ending the response
Verify canary release
Provide environment information
Which example does this report relate to?
with-passport-and-next-connect
What browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
Describe the Bug
Here in with-passport-and-next-connect
end
function is defined asasync
. This cannot be correct as it's called withoutawait
by the framework creating a race condition.This is a result of
end
@hapi\iron
apisExpected Behavior
This can be fixed either by saving the session somewhere else or by using a sync cryptography API.
To Reproduce
Run the example, see
API resolved without sending a response for /api/auth/session, this may result in stalled requests.
in the console.The text was updated successfully, but these errors were encountered: