Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update a small typo in 02-app/01-building-your-application/06-optimizing/01-images.mdx #54311

Merged
merged 2 commits into from
Aug 20, 2023
Merged

docs: update a small typo in 02-app/01-building-your-application/06-optimizing/01-images.mdx #54311

merged 2 commits into from
Aug 20, 2023

Conversation

lauthieb
Copy link
Contributor

@lauthieb lauthieb commented Aug 20, 2023

Hello,

I just make this PR because the /me.png example is not in "remote images" section but in "local images", that's why I propose to edit this :)

Thank you!

Improving Documentation

@lauthieb lauthieb changed the title docs: update a small typo for a link in `02-app/01-building-your-appl… docs: update a small typo for a link in 02-app/01-building-your-application/06-optimizing/01-images.mdx Aug 20, 2023
@lauthieb lauthieb changed the title docs: update a small typo for a link in 02-app/01-building-your-application/06-optimizing/01-images.mdx docs: update a small typo in 02-app/01-building-your-application/06-optimizing/01-images.mdx Aug 20, 2023
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to re-word this some more for clarity as this is referencing a /me.png value being provided as the source but instead the local image is showing a static image import.

This tweak is more correct than previously so seems good to land

@ijjk ijjk added the CI approved Approve running CI for fork label Aug 20, 2023
@kodiakhq kodiakhq bot merged commit 71d424e into vercel:canary Aug 20, 2023
@lauthieb lauthieb deleted the docs/images-link-typo branch August 20, 2023 19:13
@github-actions github-actions bot added the locked label Sep 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants