Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-redux-wrapper example #53817

Closed
wants to merge 6 commits into from

Conversation

BogiKay
Copy link

@BogiKay BogiKay commented Aug 9, 2023

What?

Updates to the already existing with-redux-wrapper example. PR migrates JS code to TS and since redux-toolkit is recommended it is also added to the example.

Why?

The example is a bit outdated and written in JS.

@BogiKay BogiKay requested review from a team as code owners August 9, 2023 18:42
@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 9, 2023
@leerob
Copy link
Member

leerob commented Jan 6, 2024

I would recommend removing this example in favor of with-redux: #59864

@phryneas
Copy link
Contributor

@leerob until the pages folder is deprecated, it might make sense to have an example for the pages directory, I guess - and that would be one using the redux-wrapper.

I'm not sure if it would be preferrable to have a monster example showing both the very different setup for app and pages in one example - thoughts?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants