Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic imports fix for non-webpack environments. #3414

Merged
merged 3 commits into from
Dec 8, 2017
Merged

dynamic imports fix for non-webpack environments. #3414

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
345e1c5
Added condition to check whether method exists or not
PrudviGali Nov 30, 2017
a99e87c
Conditional loop based on feature detection
PrudviGali Dec 7, 2017
3e02573
Added code comments as requested by the author
PrudviGali Dec 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/build/babel/plugins/handle-import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const TYPE_IMPORT = 'Import'

const buildImport = (args) => (template(`
(
typeof window === 'undefined' ?
typeof require.resolveWeak !== 'function' ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment where why we use this rather a simple window check.
It's better for someone who's reading the code.

new (require('next/dynamic').SameLoopPromise)((resolve, reject) => {
eval('require.ensure = function (deps, callback) { callback(require) }')
require.ensure([], (require) => {
Expand Down