dynamic imports fix for non-webpack environments. #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrudviGali
changed the title
1 task
|
Oh! I didn't see this: #3414 Sorry for that. |
arunoda
approved these changes
Dec 7, 2017
| @@ -9,7 +9,7 @@ const TYPE_IMPORT = 'Import' | |||
|
|
|||
| const buildImport = (args) => (template(` | |||
| ( | |||
| typeof window === 'undefined' ? | |||
| typeof require.resolveWeak !== 'function' ? | |||
There was a problem hiding this comment.
Could you add a comment where why we use this rather a simple window check.
It's better for someone who's reading the code.
|
@arunoda No problem. I should have added documentation in the first place. Anyhow added the requested changes. |
arunoda
approved these changes
Dec 8, 2017
|
@PrudviGali this looks great. |
|
@arunoda Cool. Thanks. |
|
Very nice, thanks @PrudviGali! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added issue description in #3345 .
Feature detection condition comes handy rather than
typeof windowbecause of webpack specific methodsrequire.resolveWeakandresolve.ensurefails in non-webpack environments.The issue was not with
windowobject but withrequire.resolveWeakandrequire.ensuremethods used in next handle-import.js file. Both these methods are specific to webpack and would not be available innode/commonjsenvironment. Jest runs in Node environment and does not recognizerequire.resolveWeakandrequire.ensuremethods.TC39 dynamic import proposal works pretty well with Jest testing. Please refer to the repo. But Nextjs implementation of dynamic imports fails in jest because of above two methods repo.
@arunoda already mentioned that should not use
process.env.NODE_ENV === 'test'in #3405. Assuming this would be the appropriate way of handling this issue #3345 .