Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup tests #13461

Merged
merged 6 commits into from
May 29, 2020
Merged

Speedup tests #13461

merged 6 commits into from
May 29, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented May 27, 2020

This PR checks if our tests can be ran faster by disabling source maps unless they're used for the purpose of testing.

@Timer
Copy link
Member Author

Timer commented May 27, 2020

Apparently this doesn't help.

@Timer Timer closed this May 27, 2020
@Timer Timer deleted the speedup-tests branch May 27, 2020 19:06
@Timer Timer restored the speedup-tests branch May 29, 2020 04:31
@Timer Timer reopened this May 29, 2020
@Timer
Copy link
Member Author

Timer commented May 29, 2020

This actually might help Windows.

@Timer
Copy link
Member Author

Timer commented May 29, 2020

Windows is way faster. Probably will be more stable, too.

@Timer Timer marked this pull request as ready for review May 29, 2020 05:35
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners May 29, 2020 05:35
@Timer Timer added this to the 9.4.5 milestone May 29, 2020
@kodiakhq kodiakhq bot merged commit 30fbd9a into vercel:canary May 29, 2020
@Timer Timer deleted the speedup-tests branch May 29, 2020 15:12
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
This PR checks if our tests can be ran faster by disabling source maps unless they're used for the purpose of testing.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants