Speedup tests (vercel#13461)

This PR checks if our tests can be ran faster by disabling source maps unless they're used for the purpose of testing.
rokinsky · Jul 11, 2020 · 782baab · 782baab
1 parent d3011da
commit 782baab
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 8 deletions.
diff --git a/packages/next/build/webpack-config.ts b/packages/next/build/webpack-config.ts
@@ -331,7 +331,12 @@ export default async function getBaseWebpackConfig(
     },
   }
 
-  const devtool = dev ? 'cheap-module-source-map' : false
+  const devtool =
+    process.env.__NEXT_TEST_MODE && !process.env.__NEXT_TEST_WITH_DEVTOOL
+      ? false
+      : dev
+      ? 'cheap-module-source-map'
+      : false
 
   const isModuleCSS = (module: { type: string }): boolean => {
     return (

diff --git a/packages/next/build/webpack/config/blocks/base.ts b/packages/next/build/webpack/config/blocks/base.ts
@@ -17,7 +17,9 @@ export const base = curry(function base(
 
   // https://webpack.js.org/configuration/devtool/#development
   if (ctx.isDevelopment) {
-    if (process.platform === 'win32') {
+    if (process.env.__NEXT_TEST_MODE && !process.env.__NEXT_TEST_WITH_DEVTOOL) {
+      config.devtool = false
+    } else if (process.platform === 'win32') {
       // Non-eval based source maps are slow to rebuild, so we only enable
       // them for Windows. Unfortunately, eval source maps are flagged as
       // suspicious by Windows Defender and block HMR.

diff --git a/test/acceptance/helpers.js b/test/acceptance/helpers.js
@@ -26,7 +26,9 @@ export async function sandbox(id = nanoid(), initialFiles = new Map()) {
   }
 
   const appPort = await findPort()
-  const app = await launchApp(sandboxDirectory, appPort)
+  const app = await launchApp(sandboxDirectory, appPort, {
+    env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
+  })
   const browser = await webdriver(appPort, '/')
 
   return [

diff --git a/test/integration/basic/test/index.test.js b/test/integration/basic/test/index.test.js
@@ -17,7 +17,9 @@ jest.setTimeout(1000 * 60 * 5)
 describe('Basic Features', () => {
   beforeAll(async () => {
     context.appPort = await findPort()
-    context.server = await launchApp(join(__dirname, '../'), context.appPort)
+    context.server = await launchApp(join(__dirname, '../'), context.appPort, {
+      env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
+    })
 
     // pre-build all pages at the start
     await Promise.all([

diff --git a/test/integration/client-navigation/test/index.test.js b/test/integration/client-navigation/test/index.test.js
@@ -21,7 +21,9 @@ jest.setTimeout(1000 * 60 * 5)
 describe('Client Navigation', () => {
   beforeAll(async () => {
     context.appPort = await findPort()
-    context.server = await launchApp(join(__dirname, '../'), context.appPort)
+    context.server = await launchApp(join(__dirname, '../'), context.appPort, {
+      env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
+    })
 
     const prerender = [
       '/async-props',

diff --git a/test/integration/getserversideprops/test/index.test.js b/test/integration/getserversideprops/test/index.test.js
@@ -564,6 +564,7 @@ describe('getServerSideProps', () => {
       stderr = ''
       appPort = await findPort()
       app = await launchApp(appDir, appPort, {
+        env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
         onStderr(msg) {
           stderr += msg
         },

diff --git a/test/integration/invalid-href/test/index.test.js b/test/integration/invalid-href/test/index.test.js
@@ -90,7 +90,9 @@ describe('Invalid hrefs', () => {
   describe('dev mode', () => {
     beforeAll(async () => {
       appPort = await findPort()
-      app = await launchApp(appDir, appPort)
+      app = await launchApp(appDir, appPort, {
+        env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
+      })
     })
     afterAll(() => killApp(app))
 

diff --git a/test/integration/prerender/test/index.test.js b/test/integration/prerender/test/index.test.js
@@ -1062,6 +1062,7 @@ describe('SSG Prerender', () => {
       )
       appPort = await findPort()
       app = await launchApp(appDir, appPort, {
+        env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
         onStderr: (msg) => {
           stderr += msg
         },
@@ -1084,7 +1085,9 @@ describe('SSG Prerender', () => {
       )
       await fs.remove(join(appDir, '.next'))
       appPort = await findPort()
-      app = await launchApp(appDir, appPort)
+      app = await launchApp(appDir, appPort, {
+        env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
+      })
     })
     afterAll(async () => {
       await fs.remove(nextConfig)

diff --git a/test/integration/typescript-hmr/test/index.test.js b/test/integration/typescript-hmr/test/index.test.js
@@ -22,6 +22,7 @@ describe('TypeScript HMR', () => {
     appPort = await findPort()
     app = await launchApp(appDir, appPort, {
       env: {
+        __NEXT_TEST_WITH_DEVTOOL: 1,
         // Events can be finicky in CI. This switches to a more reliable
         // polling method.
         CHOKIDAR_USEPOLLING: 'true',

diff --git a/test/integration/with-router/test/index.test.js b/test/integration/with-router/test/index.test.js
@@ -97,7 +97,9 @@ describe('withRouter SSR', () => {
 
   beforeAll(async () => {
     port = await findPort()
-    server = await launchApp(join(__dirname, '..'), port)
+    server = await launchApp(join(__dirname, '..'), port, {
+      env: { __NEXT_TEST_WITH_DEVTOOL: 1 },
+    })
   })
   afterAll(async () => {
     await killApp(server)