Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replaceParent reducer on termgroup exit #1494

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Fix replaceParent reducer on termgroup exit #1494

merged 1 commit into from
Feb 16, 2017

Conversation

chabou
Copy link
Collaborator

@chabou chabou commented Feb 9, 2017

activeRootGroup is not cleared when a child become a root termgroup
It happens when you exit a term with only two terms opened. The remaining termgroup containing a session replaces its parent and become root.

@chabou chabou mentioned this pull request Feb 9, 2017
Closed
iamstarkov
iamstarkov approved these changes Feb 9, 2017
View reviewed changes
Copy link
Contributor

@iamstarkov iamstarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@matheuss
Copy link
Member

@rauchg pls review 🙌

@matheuss matheuss requested a review from rauchg February 15, 2017 14:16
@rauchg rauchg merged commit 75b5eb7 into vercel:master Feb 16, 2017
@chabou chabou deleted the fix_termgroup_replaceparent branch March 5, 2017 09:57
@chabou chabou mentioned this pull request Apr 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamstarkov iamstarkov iamstarkov approved these changes

@rauchg rauchg Awaiting requested review from rauchg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chabou @matheuss @iamstarkov @rauchg