Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin error: undefined: Error occurred in reduceTermGroups. #3

Closed
kc-dot-io opened this issue Feb 9, 2017 · 18 comments
Closed

Plugin error: undefined: Error occurred in reduceTermGroups. #3

kc-dot-io opened this issue Feb 9, 2017 · 18 comments
Labels
Milestone

Comments

@kc-dot-io
Copy link

kc-dot-io commented Feb 9, 2017

Thanks for this plugin, really needed this to get hyper up to snuff for my iterm2 replacement however I'm having an issue where it's constantly throwing an error anytime I close a vertical pane.

Please see below:

screen recording 2017-02-09 at 01 31 pm 1

@chabou
Copy link
Owner

chabou commented Feb 9, 2017

Reproduced. Thank you very much for this great feedback 👌

@chabou chabou added the bug label Feb 9, 2017
@chabou
Copy link
Owner

chabou commented Feb 9, 2017

Ok this plugin hits a Hyper issue: vercel/hyper#1494

I will publish a protection, pending PR merge and Hyper release

@chabou chabou closed this as completed in 90f908c Feb 9, 2017
@chabou chabou added this to the 0.2.0 milestone Feb 9, 2017
@kc-dot-io
Copy link
Author

@chabou Thanks! Published yet?

@chabou chabou modified the milestones: 0.1.1, 0.2.0 Feb 10, 2017
@chabou
Copy link
Owner

chabou commented Feb 10, 2017

@kc-dot-io
Copy link
Author

Trying to verify with hpm uninstall / install hyper-pane and seeing same issue.

Where does hyper store installed modules?

@kc-dot-io
Copy link
Author

Nevermind, found it in ~/.hyper_plugins/node_modules/hyper-pane

Looks like the right version. Still seeing the same issue though.

@kc-dot-io
Copy link
Author

Actually, now the hotkeys do not work at all. I'll check out straight from github and confirm.

@kc-dot-io
Copy link
Author

@chabou confirmed... Rolled back to 5f7818a and the hotkeys are working, but still have the error.

@chabou
Copy link
Owner

chabou commented Feb 10, 2017

Thank you. I rolled back npm published version to 0.1.0. It is better to have an error but the hotkeys 😆
I will finally fix that over the next couple of days

@chabou
Copy link
Owner

chabou commented Feb 10, 2017

Fixed in master and release v0.1.2
But I will test it twice before push it on npm

@kc-dot-io
Copy link
Author

kc-dot-io commented Feb 10, 2017 via email

@chabou
Copy link
Owner

chabou commented Feb 10, 2017

It would be awesome !

@kc-dot-io
Copy link
Author

@chabou error is gone, so this patch works until the other one lands. Anything we need to change here when it does?

@chabou
Copy link
Owner

chabou commented Feb 10, 2017

Protection will no be useful anymore. But we will keep it for backward compatibility.
Thank you so much for your validation.
I will publish this release soon.

@chabou
Copy link
Owner

chabou commented Feb 10, 2017

Published on npm ! Thank you @slajax for your support !

@kc-dot-io
Copy link
Author

very welcome @chabou - thanks for the great plugin!

@freeall
Copy link

freeall commented Feb 23, 2017

@chabou I get this error when I open a new tab and then close it again. I am using version 1.0.0. Has it regressed somehow?

@chabou
Copy link
Owner

chabou commented Feb 24, 2017

Reproduced !

Previous fix doesn't seem bulletproof 😛
New issue opened #4, will be fixed very soon

Thank you for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants