-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript error in main process #225
Comments
Getting the exact same error when I try to use
|
Yeah @SamVerschueren. I get this error right now and I'm running |
Anyone have any insight on this? Can this exception be safely ignored? |
I no longer believe that this is related to |
I have the same issue with nyc without the 1password plugin. |
I have the same error without any plugins :( |
@isaacs If #587 and #444 actually are duplicates of this (as @matheuss has suggested by closing them in favor of this), then it doesn't even seem related to either It does seem like @rauchg's comment on #542 might be our best lead, since |
Pretty sure this is because we don't handle the |
#706 Another one, probably dup, and originating from |
@whitelynx Ah, that's interesting! I wonder if gaze is incorrectly watching files that are being created in the home directory by spawn-wrap in folders like |
I'm getting this with
|
I was able to work around this with the following patch: diff --git a/Applications/HyperTerm.app/Contents/Resources/app/node_modules/gaze/lib/gaze.js.original b/Applications/HyperTerm.app/Contents/Resources/app/node_modules/gaze/lib/gaze.js
index fe80d80..b684d35 100644
--- a/Applications/HyperTerm.app/Contents/Resources/app/node_modules/gaze/lib/gaze.js.original
+++ b/Applications/HyperTerm.app/Contents/Resources/app/node_modules/gaze/lib/gaze.js
@@ -296,9 +296,9 @@ Gaze.prototype._watchDir = function (dir, done) {
done(null, dir);
}
}, delay + 100);
- })
+ }).on('error', function (err) {})
} catch (err) {
- return this._handleError(err);
+ return this
}
return this;
}; Not sure if this is helpful, or should be sent upstream to gaze, or what. |
This commit on gaze seems to fix the error: I have hacked it in manually to my Hyperterm installation and seemed to be working like a charm. |
@H1rag4mi patched it manually and now it seems to fail only when |
Same error, also when using nyc.
|
@H1rag4mi I made the fix on my local app and I still have the errors :/ Looks like what @krzkaczor describes... |
I thought we'd bumped |
I can confirm that this is still present on 0.8.2 using the method I described above to reproduce. |
Hmm dang, I'll try @jcoetzee's repro steps today and see what's up. |
@shama thanks so much for following up 🎉 let me know when I should bump and release |
* master: chore(package): update electron to version 1.4.5 (vercel#949) add onRendererWindow, because it actually available. check ./lib/utils/plugins.js:193 (vercel#924) increase timeout for update checks (vercel#928) Change URL regex - fixes vercel#867 (vercel#943) Make the close menu items less ambiguous Comply to XO's no-warning-comments rule Prefer default export to make XO happy (vercel#931) chore(package): update ms to version 0.7.2 (vercel#933) chore(package): update copy-webpack-plugin to version 4.0.0 (vercel#927) log plugins' errors in Electron console (vercel#923) Improve tabs title (vercel#892) increase notification timeout up to 30m (vercel#913) Create github templates (vercel#919) chore(package): update electron to version 1.4.4 (vercel#907) Prevent Hterm to share same preferences between instances (vercel#906) 0.8.3 0.9.0 Revert "Quick full screen (vercel#803)" Ignore file watch errors. Fixes vercelGH-225 (vercel#893)
Is there any progress on this? I'm my office is still getting a version of this error. |
I'm also getting it, especially when doing a make and many files are being created and deleted 😟 |
What version are you running? Latest?
– @rauchg <https://twitter.com/rauchg>
…On Fri, Dec 2, 2016 at 1:40 AM, H1rag4mi ***@***.***> wrote:
I'm also getting it, especially when doing a make and many files are being
created and deleted 😟
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#225 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAy8Qx_oQs6X1k320JnSLZqLjfOCvQCks5rD2kNgaJpZM4JOdYs>
.
|
I'm on Hyper I was able to get a minimal reproduction of the error by setting: shell: 'bash -c /bin/bash' in The error dialog: Stacktrace:
|
I get this error for a long time. But sometimes, when the network is in good condition. It works. Nothing was changed with hyper. |
was there ever an official fix for this? i've been getting this error off and on for months now, and i can't seem to find a working fix for it? it seems to happen most often—at least as far as i can tell—when i have some dir or another open in hyper, and i create a new dir, delete a dir, etc. so it seems linked in some way to the watch process (obviously, i guess), and the ability to refresh the current contents of the dir. i specifically noticed this, and have been able to recreate it, when i—for example—navigate to a particular dir and then add a dir through the finder. realistically, this wouldn't be that big of a deal, except that sometimes it just seems to get caught in a loop in itself, and once i hit "OK" the error just comes up again, and again, and again, until i just force quit the application and restart it. i'm on the most recent version of hyper, and my plugins are as follows—
|
Seems to be triggered by the hypterterm-1password plugin, so it might be a problem with that extension. Figured I'd share it anyhow, since probably this shouldn't be possible anyway.
The text was updated successfully, but these errors were encountered: