-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Istanbul (nyc) code coverage causes exception in HyperTerm #357
Comments
Related: istanbuljs/nyc#324 |
This looks like it's a shortcoming in https://github.com/tapjs/spawn-wrap Since HyperTerm is using that (for some reason? I'm not aware, exactly? Probably to detect node processes and track them somehow?) and nyc uses it to wrap all node programs in Istanbul coverage, the two instances of spawn-wrap seem to be colliding with and/or overriding one another. I'm not sure of the best way to approach this. Supporting multiple wrapper programs is pretty tricky, but probably possible. (It's software! he says with sarcastic delight that hides his sinking heart.) |
As far as I can tell, HyperTerm isn't using spawn-wrap, so this is probably not a collision, but definitely some kind of weird interaction. Spawn-wrap shouldn't be breaking HyperTerm, but also, HyperTerm should not be susceptible to some program monkey-patching Node either. |
FWIW I'm seeing this issue as well |
Closing in favor of #225 |
I was looking at adding code coverage to a new node.js project I am working on, using Istanbul with Mocha.
Executing tests with code coverage enabled causes a JavaScript error to occur in the main process of HyperTerm.
A JavaScript error occurred in the main process
No matter where I run the code coverage from HyperTerm pops up the error dialog. I have tried executing the command in HyperTerm, iTerm and Terminal.
The text was updated successfully, but these errors were encountered: