-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: multiple vega-lite versions within Altair #377
Conversation
Changes look big, but the bulk of it is just rearranging existing code. |
Tests pass! @ellisonbg, would you mind taking a quick look? One thing I'm not certain on is the mirroring of altair.v1 submodules in the altair namespace. Does the way I did this make sense to you? |
Working on reviewing this: We have an example notebook that looks at I am seeing a test failure locally:
@jakevdp you were asking about mirroring the sub are you asking about how you are importing
So +1 on that unless I am misunderstanding something. |
Going to merge and iterate...we can make adjustments later if needed. |
This PR rearranges some things to allow multiple versions of Vega-Lite to be supported in a single Altair release (addresses #375). So, for example, you could do as normal
or equivalently,
Currently
v1
is the only option available, but this reorganization of the code will make it easy to add additional versions as well.