Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vega-Lite v1 and v2? #375

Closed
jakevdp opened this issue Aug 15, 2017 · 5 comments
Closed

Support Vega-Lite v1 and v2? #375

jakevdp opened this issue Aug 15, 2017 · 5 comments
Milestone

Comments

@jakevdp
Copy link
Collaborator

jakevdp commented Aug 15, 2017

A thought I had, and I was wondering if people would be in favor: we could technically support multiple versions of Vega-Lite within Altair. I would imagine structuring it something like this:

  • If you do import altair as alt, you would get the latest version
  • If you do import altair.v1 as alt, you get the syntax of altair 1.0
  • If you do import altair.v2 as alt, you get the syntax of altair 2.0

We could decide how fine-grained to be in our versions (for example, do you distinguish between v1.1 and v1.2?) I think this would be quite useful during updates like that for 2.0, where there are going to be some significant backward incompatibilites.

Thoughts on that?

@ellisonbg
Copy link
Collaborator

ellisonbg commented Aug 16, 2017 via email

@kanitw
Copy link
Member

kanitw commented Aug 16, 2017

FYI, we store JSON schema of Vega and Vega-Lite using similar pattern: v3 for latest v3, v3.1 for latest v3.1 and v3.1.1 for specific version. (See https://github.com/vega/schema/tree/master/vega-lite.)

@kanitw
Copy link
Member

kanitw commented Aug 16, 2017

Would v1 pull give the latest release or the first one.

I would vote for latest, similar to how we handle the schema. :)

@jakevdp
Copy link
Collaborator Author

jakevdp commented Aug 16, 2017

Cool – I'm working on a quick refactor of the schema generation tools that would support this.

@ellisonbg
Copy link
Collaborator

I went ahead and merged #377 - we can follow up and iterate further if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants