Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated datasets.py #3010

Merged
merged 4 commits into from
Apr 7, 2023
Merged

remove deprecated datasets.py #3010

merged 4 commits into from
Apr 7, 2023

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Apr 2, 2023

This PR removes the deprecated datasets.py.

These utilities are deprecated since 2018 4e6eb6e. I think it is save to delete this by now.

@mattijn mattijn requested a review from joelostblom April 2, 2023 20:41
@mattijn mattijn marked this pull request as draft April 2, 2023 20:43
@mattijn mattijn marked this pull request as ready for review April 2, 2023 20:51
joelostblom
joelostblom approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, and 5.0 is a good release to remove something like this. Could you add a short note to the changelog and then merge?

@mattijn
Copy link
Contributor Author

mattijn commented Apr 7, 2023

Thanks @joelostblom for checking! Done and merging.

@mattijn mattijn merged commit bb1a10f into vega:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelostblom joelostblom joelostblom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattijn @joelostblom