Skip to content

Commit

Permalink
remove deprecated datasets.py (#3010)
Browse files Browse the repository at this point in the history
* remove datasets.py

* remove unused reference in v5/__init__.py

* rerun generate_schema_wrapper.py

* update changes.rst
  • Loading branch information
mattijn authored Apr 7, 2023
1 parent d7c0b22 commit bb1a10f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 25 deletions.
1 change: 0 additions & 1 deletion altair/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,6 @@
"curry",
"data",
"data_transformers",
"datasets",
"datum",
"default_data_transformer",
"display",
Expand Down
22 changes: 0 additions & 22 deletions altair/datasets.py

This file was deleted.

2 changes: 0 additions & 2 deletions altair/vegalite/v5/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
from .schema import *
from .api import *

from ...datasets import list_datasets, load_dataset

from ...expr import datum, expr # type: ignore[no-redef]

from .display import VegaLite, renderers
Expand Down
1 change: 1 addition & 0 deletions doc/releases/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Backward-Incompatible Changes
- Colons in column names must now be escaped to remove any ambiguity with encoding types. You now need to write ``"column\:name"`` instead of ``"column:name"`` (#2824).
- Removed the Vega (v5) wrappers and deprecate rendering in Vega mode (save Chart as Vega format is still allowed) (#2829).
- Removed the Vega-Lite 3 and 4 wrappers (#2847).
- Removed the deprecated datasets.py (#3010).
- In regards to the grammar changes listed above, the old terminology will still work in many basic cases. On the other hand, if that old terminology gets used at a lower level, then it most likely will not work. For example, in the current version of :ref:`gallery_scatter_with_minimap`, two instances of the key ``param`` are used in dictionaries to specify axis domains. Those used to be ``selection``, but that usage is not compatible with the current Vega-Lite schema.

Maintenance
Expand Down

0 comments on commit bb1a10f

Please sign in to comment.