Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart changes for #579 #582

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 15, 2020

Signed-off-by: Rintaro Okamura [email protected]

Description:

Helm Chart changes for #579

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@rinx rinx force-pushed the feature/architecture/divide-gateway-and-refactor-helm-chart branch from 486087b to ba0fe01 Compare July 22, 2020 03:44
@rinx rinx marked this pull request as ready for review July 27, 2020 12:13
@rinx rinx requested a review from kpango July 27, 2020 12:13
@rinx
Copy link
Contributor Author

rinx commented Jul 27, 2020

@kpango It's ready. Please review it. 🙏

@kpango kpango force-pushed the feature/architecture/divide-gateway-and-refactor branch from 136d4f1 to 18eaad1 Compare July 28, 2020 20:36
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #582 into feature/architecture/divide-gateway-and-refactor will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                               Coverage Diff                                @@
##           feature/architecture/divide-gateway-and-refactor    #582   +/-   ##
================================================================================
  Coverage                                              9.77%   9.77%           
================================================================================
  Files                                                   450     450           
  Lines                                                 24453   24453           
================================================================================
  Hits                                                   2390    2390           
  Misses                                                21772   21772           
  Partials                                                291     291           
Impacted Files Coverage Δ
internal/errgroup/group.go 93.42% <0.00%> (-1.32%) ⬇️
internal/file/watch/watch.go 92.03% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7e5b6...ffc2344. Read the comment docs.

kpango and others added 15 commits July 29, 2020 06:27
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
@kpango kpango force-pushed the feature/architecture/divide-gateway-and-refactor-helm-chart branch from f87b538 to ffc2344 Compare July 28, 2020 22:16
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 01191a9 into feature/architecture/divide-gateway-and-refactor Jul 30, 2020
@kpango kpango deleted the feature/architecture/divide-gateway-and-refactor-helm-chart branch July 30, 2020 03:53
kpango pushed a commit that referenced this pull request Jul 30, 2020
* [patch] divide gateway for future architecture

Signed-off-by: kpango <[email protected]>

* 🔥 clean

Signed-off-by: Rintaro Okamura <[email protected]>

* 🔧 fix type signature

Signed-off-by: Rintaro Okamura <[email protected]>

* ♻️ hierarchical structure values for manager components

Signed-off-by: Rintaro Okamura <[email protected]>

* ♻️ use variable for root object: agent

Signed-off-by: Rintaro Okamura <[email protected]>

* ♻️ use variable for root object: discoverer

Signed-off-by: Rintaro Okamura <[email protected]>

* ♻️ use variable for root object: gateway

Signed-off-by: Rintaro Okamura <[email protected]>

* ♻️ use variable for root object: meta

Signed-off-by: Rintaro Okamura <[email protected]>

* ♻️ move gateway to gateway.vald

Signed-off-by: Rintaro Okamura <[email protected]>

* 🚚 update existing values structure

Signed-off-by: Rintaro Okamura <[email protected]>

* ✨ add gateways

Signed-off-by: Rintaro Okamura <[email protected]>

* 🚧 add templates for gateways

Signed-off-by: Rintaro Okamura <[email protected]>

* 🔧 add gateway configs

Signed-off-by: Rintaro Okamura <[email protected]>

* ✨ add initContainer templates for wait-for-gateway-*

Signed-off-by: Rintaro Okamura <[email protected]>

* 🔧 add gateway client addrs

Signed-off-by: Rintaro Okamura <[email protected]>

Co-authored-by: kpango <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants