-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Chart changes for #579 #582
Helm Chart changes for #579 #582
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
[CHATOPS:HELP] ChatOps commands.
|
486087b
to
ba0fe01
Compare
@kpango It's ready. Please review it. 🙏 |
136d4f1
to
18eaad1
Compare
Codecov Report
@@ Coverage Diff @@
## feature/architecture/divide-gateway-and-refactor #582 +/- ##
================================================================================
Coverage 9.77% 9.77%
================================================================================
Files 450 450
Lines 24453 24453
================================================================================
Hits 2390 2390
Misses 21772 21772
Partials 291 291
Continue to review full report at Codecov.
|
Signed-off-by: kpango <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
Signed-off-by: Rintaro Okamura <[email protected]>
f87b538
to
ffc2344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [patch] divide gateway for future architecture Signed-off-by: kpango <[email protected]> * 🔥 clean Signed-off-by: Rintaro Okamura <[email protected]> * 🔧 fix type signature Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ hierarchical structure values for manager components Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use variable for root object: agent Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use variable for root object: discoverer Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use variable for root object: gateway Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ use variable for root object: meta Signed-off-by: Rintaro Okamura <[email protected]> * ♻️ move gateway to gateway.vald Signed-off-by: Rintaro Okamura <[email protected]> * 🚚 update existing values structure Signed-off-by: Rintaro Okamura <[email protected]> * ✨ add gateways Signed-off-by: Rintaro Okamura <[email protected]> * 🚧 add templates for gateways Signed-off-by: Rintaro Okamura <[email protected]> * 🔧 add gateway configs Signed-off-by: Rintaro Okamura <[email protected]> * ✨ add initContainer templates for wait-for-gateway-* Signed-off-by: Rintaro Okamura <[email protected]> * 🔧 add gateway client addrs Signed-off-by: Rintaro Okamura <[email protected]> Co-authored-by: kpango <[email protected]>
Signed-off-by: Rintaro Okamura [email protected]
Description:
Helm Chart changes for #579
Related Issue:
nothing
How Has This Been Tested?:
nothing
Environment:
Types of changes:
Changes to Core Features:
Checklist: