[patch] divide gateway for future architecture

[kpango]

Signed-off-by: kpango [email protected]

Description:

This PR includes a lot of feature.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (38 warnings, 2 commits squashed)

[patch] divide gateway for future architecture

...way/vald/router/router_test.go 50% changes removed in fix

...dex/service/indexinfos_test.go 93% changes removed in fix

...ckup/mysql/model/model_test.go 80% changes removed in fix

...mpressor/router/router_test.go 50% changes removed in fix

...erer/k8s/router/router_test.go 50% changes removed in fix

.../gateway/backup/configmap.yaml 55% changes removed in Helm Chart changes f...

.../service/podmetricsmap_test.go 94% changes removed in fix

...ates/gateway/lb/configmap.yaml 41% changes removed in Helm Chart changes f...

...handler/grpc/checklist_test.go 88% changes removed in fix

...er/index/router/router_test.go 50% changes removed in fix

...re/ngt/service/vcaches_test.go 93% changes removed in fix

...ntroller/router/router_test.go 50% changes removed in fix

...roller/service/nodemap_test.go 94% changes removed in fix

...ta/redis/router/router_test.go 50% changes removed in fix

...ay/vald/vald/vald.swagger.json 56% changes removed in [patch] divide gatew...

...up/mysql/router/router_test.go 50% changes removed in fix

...er/k8s/service/nodemap_test.go 94% changes removed in fix

...es/gateway/meta/configmap.yaml 55% changes removed in Helm Chart changes f...

...re/ngt/handler/rest/handler.go 50% changes removed in [patch] divide gatew...

...roller/service/podsmap_test.go 94% changes removed in fix

...assandra/router/router_test.go 50% changes removed in fix

...service/nodemetricsmap_test.go 94% changes removed in fix

...gt/handler/rest/option_test.go 50% changes removed in [patch] divide gatew...

.../gateway/filter/configmap.yaml 55% changes removed in Helm Chart changes f...

...on/agent/router/router_test.go 50% changes removed in fix

...er/k8s/service/podsmap_test.go 94% changes removed in fix

...core/ngt/router/router_test.go 50% changes removed in fix

go.mod 72% changes removed in fix

...re/ngt/service/kvs/kvs_test.go 89% changes removed in fix

...ore/ngt/service/kvs/uo_test.go 93% changes removed in fix

...ore/ngt/service/kvs/ou_test.go 92% changes removed in fix

...assandra/router/router_test.go 50% changes removed in fix

.../sidecar/router/router_test.go 50% changes removed in fix

hack/go.mod.default 86% changes removed in fix

.../service/podmetricsmap_test.go 94% changes removed in fix

...service/nodemetricsmap_test.go 94% changes removed in fix

     Apply suggestions from code review

fix

...nt/handler/rest/option_test.go 71% changes removed in fix

...loadtest/config/config_test.go 44% changes removed in fix

...way/vald/config/config_test.go 50% changes removed in fix

go.mod 58% changes removed in fix

hack/go.mod.default 80% changes removed in fix

...way/vald/router/router_test.go 50% changes removed in fix

...ld/handler/rest/option_test.go 50% changes removed in fix

.../service/filter_option_test.go 50% changes removed in fix

Helm Chart changes for #579 (#582)

...es/manager/compressor/svc.yaml 42% changes removed in Helm Chart changes f...

.../templates/discoverer/svc.yaml 42% changes removed in Helm Chart changes f...

...mplates/agent/sidecar-svc.yaml 42% changes removed in Helm Chart changes f...

...s/vald/templates/meta/hpa.yaml 50% changes removed in Helm Chart changes f...

.../vald/templates/agent/hpa.yaml 50% changes removed in Helm Chart changes f...

.../vald/templates/agent/svc.yaml 42% changes removed in Helm Chart changes f...

...mplates/agent/statefulset.yaml 44% changes removed in Helm Chart changes f...

...lues-agent-ngt-standalone.yaml 44% changes removed in Helm Chart changes f...

charts/vald/values-ci.yaml 86% changes removed in Helm Chart changes f...

...emplates/gateway/vald/svc.yaml 42% changes removed in Helm Chart changes f...

...plates/manager/backup/hpa.yaml 50% changes removed in Helm Chart changes f...

.../templates/discoverer/hpa.yaml 50% changes removed in Helm Chart changes f...

...mplates/manager/index/svc.yaml 42% changes removed in Helm Chart changes f...

charts/vald/values-dev.yaml 86% changes removed in Helm Chart changes f...

...emplates/gateway/vald/ing.yaml 89% changes removed in Helm Chart changes f...

...plates/manager/backup/svc.yaml 42% changes removed in Helm Chart changes f...

charts/vald/values-scylla.yaml 80% changes removed in Helm Chart changes f...

...s/vald/templates/meta/svc.yaml 42% changes removed in Helm Chart changes f...

...es/manager/compressor/hpa.yaml 50% changes removed in Helm Chart changes f...

...es/discoverer/clusterrole.yaml 50% changes removed in Helm Chart changes f...

...emplates/gateway/vald/hpa.yaml 50% changes removed in Helm Chart changes f...

...rts/vald/values-cassandra.yaml 79% changes removed in Helm Chart changes f...

[patch] divide gateway for future architecture

...ockers/gateway/meta/Dockerfile 46% changes removed in fix

...pc/gateway/filter/filter.pb.go 61% changes removed in fix

...roller/service/nodemap_test.go 94% changes removed in fix

...way/meta/config/config_test.go 47% changes removed in fix

...way/vald/router/router_test.go 50% changes removed in fix

...ckup/mysql/model/model_test.go 80% changes removed in fix

.../sidecar/router/router_test.go 50% changes removed in fix

...er/k8s/service/nodemap_test.go 94% changes removed in fix

...erer/k8s/router/router_test.go 50% changes removed in fix

.../gateway/backup/configmap.yaml 55% changes removed in Helm Chart changes f...

.../filter/handler/rest/option.go 66% changes removed in fix

...up/mysql/router/router_test.go 50% changes removed in fix

dockers/gateway/lb/Dockerfile 48% changes removed in fix

...service/nodemetricsmap_test.go 94% changes removed in fix

...mpressor/router/router_test.go 50% changes removed in fix

...es/gateway/meta/configmap.yaml 55% changes removed in Helm Chart changes f...

...y/backup/config/config_test.go 47% changes removed in fix

.../service/podmetricsmap_test.go 94% changes removed in fix

...re/ngt/service/vcaches_test.go 93% changes removed in fix

...ta/redis/router/router_test.go 50% changes removed in fix

...roller/service/podsmap_test.go 94% changes removed in fix

...re/ngt/service/kvs/kvs_test.go 89% changes removed in fix

...y/filter/router/router_test.go 47% changes removed in fix

...assandra/router/router_test.go 50% changes removed in fix

.../service/podmetricsmap_test.go 94% changes removed in fix

...teway/lb/config/config_test.go 47% changes removed in fix

...on/agent/router/router_test.go 50% changes removed in fix

...s/grpc/gateway/vald/vald.pb.go 41% changes removed in fix

...core/ngt/router/router_test.go 50% changes removed in fix

go.mod 64% changes removed in fix

...er/k8s/service/podsmap_test.go 94% changes removed in fix

...teway/filter/service/filter.go 81% changes removed in fix

...dex/service/indexinfos_test.go 93% changes removed in fix

...ter/filter/filter.swagger.json 66% changes removed in fix

...kers/gateway/backup/Dockerfile 46% changes removed in fix

...ateway/filter/router/router.go 52% changes removed in fix

...assandra/router/router_test.go 50% changes removed in fix

...ss/ingress_filter.swagger.json 64% changes removed in fix

hack/go.mod.default 97% changes removed in fix

...y/lb/handler/grpc/visitlist.go 54% changes removed in fix

...is/grpc/agent/core/agent.pb.go 96% changes removed in fix

.../gateway/filter/configmap.yaml 55% changes removed in Helm Chart changes f...

...tool/location/location_test.go 45% changes removed in fix

.../filter/handler/grpc/option.go 69% changes removed in fix

...ates/gateway/lb/configmap.yaml 41% changes removed in Helm Chart changes f...

...teway/lb/router/router_test.go 47% changes removed in fix

...ore/ngt/service/kvs/ou_test.go 92% changes removed in fix

...y/filter/config/config_test.go 47% changes removed in fix

...handler/grpc/checklist_test.go 88% changes removed in fix

...ore/ngt/service/kvs/uo_test.go 93% changes removed in fix

...service/nodemetricsmap_test.go 94% changes removed in fix

...y/backup/router/router_test.go 47% changes removed in fix

...ntroller/router/router_test.go 50% changes removed in fix

...way/meta/router/router_test.go 47% changes removed in fix

...er/index/router/router_test.go 50% changes removed in fix

Apply suggestions from code review

Makefile.d/docker.mk 50% changes removed in fix

fix

go.mod 75% changes removed in fix

...ra/handler/grpc/option_test.go 43% changes removed in fix

.../service/filter_option_test.go 50% changes removed in fix

go.sum 51% changes removed in Merge branch 'master...

...tool/location/location_test.go 50% changes removed in fix

...r/handler/rest/handler_test.go 50% changes removed in fix

...ra/handler/rest/option_test.go 43% changes removed in fix

...gt/handler/rest/option_test.go 43% changes removed in fix

...y/backup/router/router_test.go 50% changes removed in fix

...8s/handler/grpc/option_test.go 43% changes removed in fix

...up/handler/rest/option_test.go 50% changes removed in fix

...ql/handler/grpc/option_test.go 43% changes removed in fix

...ta/handler/rest/option_test.go 50% changes removed in fix

...way/meta/router/router_test.go 50% changes removed in fix

...is/handler/grpc/option_test.go 43% changes removed in fix

...ld/handler/rest/option_test.go 50% changes removed in fix

...loadtest/config/config_test.go 44% changes removed in fix

...way/meta/config/config_test.go 50% changes removed in fix

...teway/lb/config/config_test.go 50% changes removed in fix

...ar/handler/grpc/option_test.go 43% changes removed in fix

...y/backup/config/config_test.go 50% changes removed in fix

...er/handler/rest/option_test.go 50% changes removed in fix

...y/filter/router/router_test.go 50% changes removed in fix

...lb/handler/rest/option_test.go 50% changes removed in fix

...ex/handler/rest/option_test.go 43% changes removed in fix

...or/handler/rest/option_test.go 43% changes removed in fix

...8s/handler/rest/option_test.go 43% changes removed in fix

...x/handler/grpc/handler_test.go 50% changes removed in fix

...teway/lb/router/router_test.go 50% changes removed in fix

...ex/handler/grpc/option_test.go 43% changes removed in fix

...nt/handler/rest/option_test.go 43% changes removed in fix

...ar/handler/rest/option_test.go 43% changes removed in fix

...y/filter/config/config_test.go 50% changes removed in fix

...r/handler/rest/handler_test.go 50% changes removed in fix

...way/vald/router/router_test.go 50% changes removed in fix

...ra/handler/rest/option_test.go 43% changes removed in fix

...nt/handler/grpc/option_test.go 43% changes removed in fix

...ra/handler/grpc/option_test.go 43% changes removed in fix

...ql/handler/rest/option_test.go 43% changes removed in fix

...is/handler/rest/option_test.go 43% changes removed in fix

...er/handler/grpc/option_test.go 43% changes removed in fix

...way/vald/config/config_test.go 50% changes removed in fix

...er/handler/rest/option_test.go 43% changes removed in fix

     Helm Chart changes for #579 (#582)

     Merge branch 'feature/architecture/divide-gateway-and-refactor' of htt...

fix

...is/proto/payload/payload.proto 71% changes removed in fix

...pis/grpc/payload/payload.pb.go 68% changes removed in fix

...agger/vald/search.swagger.json 99% changes removed in fix

apis/grpc/vald/search.pb.go 57% changes removed in fix

...ter/egress/egress_filter.pb.go 71% changes removed in fix

...agger/vald/object.swagger.json 98% changes removed in fix

...agger/vald/update.swagger.json 98% changes removed in fix

go.sum 79% changes removed in fix

...agger/vald/remove.swagger.json 98% changes removed in fix

...agger/vald/insert.swagger.json 98% changes removed in fix

...agger/vald/upsert.swagger.json 99% changes removed in fix

go.mod 86% changes removed in fix

Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

internal/db/kvs/redis/redis.go 61% changes removed in Merge branch 'featur...

...cli/loadtest/assets/dataset.go 68% changes removed in fix

fix

...ndra/service/cassandra_test.go 75% changes removed in fix

...ndra/service/cassandra_test.go 70% changes removed in fix

...b/nosql/cassandra/cassandra.go 44% changes removed in fix

...servability/metrics/metrics.go 50% changes removed in Merge branch 'master...

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

fix

internal/tls/tls.go 54% changes removed in fix

go.sum 60% changes removed in fix

fix

go.mod 75% changes removed in Merge branch 'master...

Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

...s/cli/loadtest/usecase/load.go 57% changes removed in fix

fix

apis/proto/vald/remove.proto 50% changes removed in fix

apis/proto/vald/search.proto 50% changes removed in fix

apis/proto/vald/update.proto 50% changes removed in fix

apis/proto/vald/upsert.proto 50% changes removed in fix

apis/proto/vald/insert.proto 50% changes removed in fix

apis/proto/vald/object.proto 50% changes removed in fix

fix

go.mod 75% changes removed in Merge branch 'master...

go.sum 60% changes removed in Merge branch 'master...

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

fix

go.mod 86% changes removed in fix

go.sum 62% changes removed in fix

     fix

fix ... fix

Squashed 2 commits:

• fix

• fix

fix

go.mod 50% changes removed in fix

hack/go.mod.default 50% changes removed in Merge branch 'master...

fix

apis/docs/vald/v1/docs.md 67% changes removed in fix

     fix

Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

...nal/db/rdb/mysql/model_test.go 64% changes removed in fix

...kg/meta/redis/service/redis.go 40% changes removed in Merge branch 'featur...

...al/db/rdb/mysql/option_test.go 45% changes removed in fix

.../backup/mysql/service/mysql.go 43% changes removed in Merge branch 'featur...

...l/compress/zstd_option_test.go 65% changes removed in Merge branch 'featur...

...l/compress/gzip_option_test.go 57% changes removed in Merge branch 'featur...

fix

go.mod 49% changes removed in fix

hack/go.mod.default 80% changes removed in fix

...is/grpc/agent/core/agent.pb.go 92% changes removed in fix

     Merge branch 'feature/architecture/divide-gateway-and-refactor' of htt...

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

hack/go.mod.default 50% changes removed in Merge branch 'master...

go.mod 56% changes removed in fix

hack/git/hooks/pre-commit 50% changes removed in fix

fix

...to/agent/sidecar/sidecar.proto 50% changes removed in fix

Makefile 50% changes removed in fix

...is/grpc/agent/core/agent.pb.go 83% changes removed in fix

fix

go.sum 65% changes removed in fix

go.mod 45% changes removed in fix

hack/go.mod.default 50% changes removed in fix

fix

go.mod 50% changes removed in fix

fix

...roto/v1/agent/core/agent.proto 50% changes removed in fix pbdoc task (#710...

...pis/proto/v1/vald/remove.proto 50% changes removed in fix pbdoc task (#710...

...ager/index/index_manager.proto 50% changes removed in fix pbdoc task (#710...

...v1/discoverer/discoverer.proto 50% changes removed in fix pbdoc task (#710...

...ter/egress/egress_filter.proto 50% changes removed in fix pbdoc task (#710...

...pis/proto/v1/vald/upsert.proto 50% changes removed in fix pbdoc task (#710...

...v1/agent/sidecar/sidecar.proto 50% changes removed in fix

...er/backup/backup_manager.proto 50% changes removed in fix pbdoc task (#710...

...er/compressor/compressor.proto 50% changes removed in fix pbdoc task (#710...

...pis/proto/v1/vald/insert.proto 50% changes removed in fix pbdoc task (#710...

...pis/proto/v1/vald/update.proto 50% changes removed in fix pbdoc task (#710...

go.sum 75% changes removed in Merge branch 'master...

...to/discoverer/discoverer.proto 50% changes removed in fix pbdoc task (#710...

...ter/egress/egress_filter.proto 50% changes removed in fix

...ller/replication_manager.proto 50% changes removed in fix pbdoc task (#710...

...ager/index/index_manager.proto 50% changes removed in fix pbdoc task (#710...

...pis/proto/v1/vald/search.proto 50% changes removed in fix pbdoc task (#710...

...gent/replication_manager.proto 50% changes removed in fix pbdoc task (#710...

...pis/proto/v1/vald/object.proto 50% changes removed in fix pbdoc task (#710...

...r/ingress/ingress_filter.proto 50% changes removed in fix pbdoc task (#710...

...gent/replication_manager.proto 50% changes removed in fix pbdoc task (#710...

apis/proto/meta/meta.proto 50% changes removed in fix pbdoc task (#710...

...ller/replication_manager.proto 50% changes removed in fix pbdoc task (#710...

...er/backup/backup_manager.proto 50% changes removed in fix pbdoc task (#710...

...r/ingress/ingress_filter.proto 50% changes removed in fix pbdoc task (#710...

...oto/v1/gateway/vald/vald.proto 50% changes removed in fix pbdoc task (#710...

...pis/proto/v1/vald/filter.proto 50% changes removed in fix pbdoc task (#710...

...to/gateway/filter/filter.proto 50% changes removed in fix pbdoc task (#710...

.../proto/gateway/vald/vald.proto 50% changes removed in fix pbdoc task (#710...

...er/compressor/compressor.proto 50% changes removed in fix pbdoc task (#710...

apis/proto/v1/meta/meta.proto 50% changes removed in fix pbdoc task (#710...

Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

...PLATE/security_issue_report.md 50% changes removed in Merge branch 'master...

go.sum 53% changes removed in fix

...ithub/PULL_REQUEST_TEMPLATE.md 50% changes removed in Merge branch 'master...

...b/ISSUE_TEMPLATE/bug_report.md 50% changes removed in Merge branch 'master...

go.mod 71% changes removed in fix

...s/manager/index/configmap.yaml 67% changes removed in Merge branch 'master...

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

fix

...pis/proto/v1/vald/remove.proto 50% changes removed in fix

.../traffic/traffic_manager.pb.go 45% changes removed in fix

...pc/agent/sidecar/sidecar.pb.go 93% changes removed in fix

go.mod 67% changes removed in fix

fix

...handler/grpc/visitlist_test.go 50% changes removed in fix

...on/agent/config/config_test.go 50% changes removed in fix

...decar/usecase/sidecard_test.go 50% changes removed in fix

...ta/redis/config/config_test.go 50% changes removed in fix

...ntroller/config/config_test.go 50% changes removed in fix

...ar/handler/grpc/option_test.go 67% changes removed in fix

...assandra/config/config_test.go 50% changes removed in fix

...way/vald/config/config_test.go 50% changes removed in fix

...core/ngt/config/config_test.go 50% changes removed in fix

...mpressor/config/config_test.go 50% changes removed in fix

...nt/handler/grpc/option_test.go 67% changes removed in fix

...nt/handler/rest/option_test.go 67% changes removed in fix

...up/mysql/config/config_test.go 50% changes removed in fix

...assandra/config/config_test.go 50% changes removed in fix

...ar/handler/rest/option_test.go 67% changes removed in fix

...erer/k8s/config/config_test.go 50% changes removed in fix

...er/index/config/config_test.go 50% changes removed in fix

Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

...8s/discoverer/clusterrole.yaml 67% changes removed in Merge branch 'master...

...overer/clusterrolebinding.yaml 67% changes removed in Merge branch 'master...

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

fix

go.mod 50% changes removed in fix

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

fix

...y/meta/handler/rest/handler.go 50% changes removed in fix

Makefile 67% changes removed in fix

.../filter/handler/rest/option.go 50% changes removed in fix

...way/lb/handler/rest/handler.go 50% changes removed in fix

...backup/handler/rest/handler.go 50% changes removed in fix

...filter/handler/grpc/handler.go 50% changes removed in fix

...filter/handler/rest/handler.go 50% changes removed in fix

...backup/handler/grpc/handler.go 50% changes removed in fix

fix

.../filter/service/filter_test.go 97% changes removed in fix

apis/grpc/v1/vald/upsert.pb.go 46% changes removed in fix pbdoc task (#710...

...service/gateway_option_test.go 72% changes removed in fix

...r/handler/grpc/handler_test.go 99% changes removed in fix

...replication/controller/docs.md 47% changes removed in fix pbdoc task (#710...

.../backup/service/backup_test.go 97% changes removed in fix

...b/handler/rest/handler_test.go 43% changes removed in fix

...p/handler/grpc/handler_test.go 99% changes removed in fix

...way/lb/service/gateway_test.go 81% changes removed in fix

     fix

     fix

fix

k8s/agent/configmap.yaml 67% changes removed in Merge branch 'master...

charts/vald/README.md 67% changes removed in Merge branch 'master...

...ter/egress/egress_filter.pb.go 90% changes removed in fix pbdoc task (#710...

Makefile.d/proto.mk 50% changes removed in fix pbdoc task (#710...

...replication/controller/docs.md 67% changes removed in fix pbdoc task (#710...

fix pbdoc task (#710)

apis/proto/meta/meta.proto 50% changes removed in fix

...gent/replication_manager.proto 50% changes removed in fix

apis/docs/v0/docs.md 62% changes removed in fix

...r/ingress/ingress_filter.proto 50% changes removed in fix

.../proto/gateway/vald/vald.proto 83% changes removed in fix

...er/compressor/compressor.proto 78% changes removed in fix

...er/backup/backup_manager.proto 88% changes removed in fix

...ter/egress/egress_filter.proto 50% changes removed in fix

...ager/index/index_manager.proto 50% changes removed in fix

...ter/egress/egress_filter.pb.go 85% changes removed in fix

...pis/proto/v1/vald/filter.proto 50% changes removed in fix

     fix

     Merge remote-tracking branch 'origin/master' into feature/architecture...

fix

go.mod 80% changes removed in fix

go.sum 57% changes removed in fix

     fix

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

fix

go.mod 50% changes removed in fix

     fix

     fix

     fix

     fix

fix

...ateway/filter/router/router.go 47% changes removed in fix

     fix

     Merge branch 'master' into feature/architecture/divide-gateway-and-ref...

fix

...tool/location/location_test.go 57% changes removed in fix

     fix

     fix

     fix

     fix

     fix

     fix

fix

dockers/gateway/lb/Dockerfile 67% changes removed in fix

...ockers/gateway/meta/Dockerfile 67% changes removed in fix

...kers/gateway/backup/Dockerfile 67% changes removed in fix

     fix

     fix

     fix

     fix

     fix

     fix

Powered by Pull Assistant. Last update 01c785d ... 198c446. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[vdaas-ci]

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

[codecov]

Codecov Report

Merging #579 into master will decrease coverage by 3.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   15.78%   11.92%   -3.86%     
==========================================
  Files         421      458      +37     
  Lines       19536    22931    +3395     
==========================================
- Hits         3083     2734     -349     
- Misses      16226    19960    +3734     
- Partials      227      237      +10     

Impacted Files	Coverage Δ
cmd/gateway/backup/main.go	0.00% <ø> (ø)
cmd/gateway/lb/main.go	0.00% <ø> (ø)
cmd/gateway/meta/main.go	0.00% <ø> (ø)
hack/helm/schema/gen/main.go	0.00% <ø> (ø)
hack/license/gen/main.go	0.00% <ø> (ø)
hack/tools/metrics/main.go	0.00% <ø> (ø)
internal/backoff/backoff.go	83.67% <ø> (-3.00%)	⬇️
internal/client/agent/grpc/client.go	0.00% <ø> (ø)
internal/client/gateway/vald/grpc/client.go	0.00% <ø> (ø)
internal/client/gateway/vald/option.go	0.00% <ø> (ø)
... and 117 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3caef54...09a5160. Read the comment docs.

[kpango]

/rebase
/format

[vdaas-ci]

[REBASE] Rebase triggered by kpango for branch: feature/architecture/divide-gateway-and-refactor

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

[kevindiu]

I think it should be minor or major release 🤔

[rinx]

still reviewing.

[rinx]

In this PR, search, insert, update operations in core/agent.proto are removed and a service in gatway/vald/vald.proto is implemented to agent-NGT.
however, before reviewing this PR, I imagined that restructuring of proto files would be done by:

• remove gateway/vald/vald.proto
• remove search, insert, update operations in core/agent.proto.
• add primitive services about ANNs
  • InsertService
    • provides Insert, StreamInsert, MultiInsert
  • SearchService
    • provides Search, StreamSearch, SearchByID, ...
  • UpdateService
  • DeleteService

and these services are implemented to agent-NGT and all new gateways.
i think it's more flexible than the current definition.

and in the current implementation, agent-NGT implements the Vald service that is defined in gateway/vald/vald.proto.
i think it's a little bit strange that "agent has gateway's service". it should be "gateway has agent's Insert, Search, Update, and Delete services".

How do you think about it?

[rinx]

this PR is closed because the #740, #826 has same feature.